broken commit, attempting to add root bone insertion feature which doesn't just copy hip bones.

Author: RichardPerry

__init__.py

@@ -24,7 +24,7 @@
 bl_info = {
     "name": "Mixamo Root",
     "author": "Richard Perry, Johngoss725",
-    "version": (1, 1, 2),
+    "version": (1, 2, 2),
     "blender": (2, 80, 0),
     "location": "3D View > UI (Right Panel) > Mixamo Tab",
     "description": ("Script to bake insert root motion bone for Mixamo Animations"),
@@ -148,6 +148,27 @@ def execute(self, context):
         mixamoroot.apply_all_anims(delete_applied_armatures=delete_applied_armatures, control_rig=control_rig, push_nla=push_nla)
         return{ 'FINISHED'}
 
+class OBJECT_OT_AddRootNLA(bpy.types.Operator):
+    '''Operator for adding a root bone to all animations to in the NLA, including keyframes'''
+    bl_idname = "mixamo.addrootnla"
+    bl_label = "Add Root"
+    bl_description = "Adds a root bone to all animation strips in the NLA for the selected armature, iterating through every keyframe and copying the hip position. Sets the Z coordinate to a minimum of 0"
+
+    # Works on the selected armature only
+    def execute(self, context):
+        mixamo = context.scene.mixamo
+        hip_name = mixamo.hip_name
+        root_name = mixamo.root_name
+        name_prefix = mixamo.name_prefix
+        if hip_name == '':
+            self.report({'ERROR_INVALID_INPUT'}, "Error: no Hip Bone Name set.")
+            return{ 'CANCELLED'}
+        if root_name == '':
+            self.report({'ERROR_INVALID_INPUT'}, "Error: no Root Bone Name set.")
+            return{ 'CANCELLED'}
+        mixamoroot.add_root_bone_nla(root_bone_name=root_name, hip_bone_name=hip_name, name_prefix=name_prefix)
+        return{ 'FINISHED'}
+
 class MIXAMOCONV_VIEW_3D_PT_mixamoroot(bpy.types.Panel):
     """Creates a Tab in the Toolshelve in 3D_View"""
     bl_label = "Mixamo Root"
@@ -197,11 +218,16 @@ def draw(self, context):
         row = box.row()
         # box.prop(scene.mixamo, "mixamo.applyanims") # todo
         row.operator("mixamo.applyanims")
+        row = box.row()
+        row.scale_y = 2.0
+        row.operator("mixamo.addrootnla")
+        status_row = box.row()
         # status_row = box.row()
 
 classes = (
     OBJECT_OT_ImportAnimations,
     OBJECT_OT_ApplyAnimations,
+    OBJECT_OT_AddRootNLA,
     MIXAMOCONV_VIEW_3D_PT_mixamoroot,
 )
 
@@ -217,7 +243,8 @@ def register():
     '''
     bpy.utils.register_class(OBJECT_OT_ImportAnimations)
     bpy.utils.register_class(OBJECT_OT_ApplyAnimations)
-    bpy.utils.unregister_class(MixamorootPanel)
+    bpy.utils.register_class(OBJECT_OT_AddRootNLA)
+    bpy.utils.register_class(MixamorootPanel)
     '''
 
 def unregister():
@@ -226,8 +253,9 @@ def unregister():
     bpy.utils.unregister_class(MixamoPropertyGroup)    
     '''
     bpy.utils.unregister_class(MixamoPropertyGroup)
-    bpy.utils.register_class(OBJECT_OT_ImportAnimations)
-    bpy.utils.register_class(OBJECT_OT_ApplyAnimations)
+    bpy.utils.uregister_class(OBJECT_OT_ImportAnimations)
+    bpy.utils.uregister_class(OBJECT_OT_ApplyAnimations)
+    bpy.utils.unregister_class(OBJECT_OT_AddRootNLA)
     bpy.utils.unregister_class(MixamorootPanel)
     '''
     del bpy.types.Scene.mixamo_control_rig

mixamoroot.py

@@ -116,6 +116,144 @@ def copyHips(root_bone_name="Root", hip_bone_name="mixamorig:Hips", name_prefix=
     bpy.context.area.ui_type = 'VIEW_3D'
     bpy.ops.object.mode_set(mode='OBJECT')
 
+def fix_bones_nla(remove_prefix=False, name_prefix="mixamorig:"):
+    bpy.ops.object.mode_set(mode = 'OBJECT')
+        
+    if not bpy.ops.object:
+        log.warning('[Mixamo Root] Could not find amature object, please select the armature')
+
+    bpy.ops.object.transform_apply(location=True, rotation=True, scale=True)
+    bpy.context.object.show_in_front = True
+
+def scale_all_nla(armature):
+    bpy.ops.object.mode_set(mode='OBJECT')
+
+    # prev_context=bpy.context.area.type
+
+    for track in [x for x in armature.animation_data.nla_tracks]:
+        bpy.context.active_nla_track = track
+        for strip in track.strips:
+            bpy.context.active_nla_strip = strip
+            print(bpy.context.active_nla_strip)
+
+        
+    bpy.ops.object.mode_set(mode='POSE')
+    bpy.ops.pose.select_all(action='SELECT')
+    bpy.context.area.type = 'GRAPH_EDITOR'
+    bpy.context.space_data.dopesheet.filter_text = "Location"
+    bpy.context.space_data.pivot_point = 'CURSOR'
+    bpy.context.space_data.dopesheet.use_filter_invert = False
+    
+    bpy.ops.anim.channels_select_all(action='SELECT')   
+        
+    bpy.ops.transform.resize(value=(1, 0.01, 1), orient_type='GLOBAL',
+    orient_matrix=((1, 0, 0), (0, 1, 0), (0, 0, 1)),
+    orient_matrix_type='GLOBAL',
+    constraint_axis=(False, True, False),
+    mirror=True, use_proportional_edit=False,
+    proportional_edit_falloff='SMOOTH',
+    proportional_size=1,
+    use_proportional_connected=False,
+    use_proportional_projected=False)
+
+def copy_hips_nla(root_bone_name="Root", hip_bone_name="mixamorig:Hips", name_prefix="mixamorig:"):
+    hip_bone_name="Ctrl_Hips"
+    bpy.ops.object.mode_set(mode='POSE')
+    previous_context = bpy.context.area.ui_type
+    bpy.ops.pose.select_all(action='DESELECT')
+    while False:
+        #SELECT OUR ROOT MOTION BONE 
+        # bpy.context.object.pose.bones[name_prefix + root_bone_name].bone.select = True
+
+        # bpy.ops.nla.tweakmode_enter()
+        # bpy.context.area.ui_type = 'FCURVES'
+        
+        # # SET FRAME TO ZERO
+        # bpy.ops.graph.cursor_set(frame=0.0, value=0.0)
+        # #ADD NEW KEYFRAME
+        # bpy.ops.anim.keyframe_insert_menu(type='Location')
+        # #SELECT ONLY HIPS AND LOCTAIUON GRAPH DATA
+        # bpy.ops.pose.select_all(action='DESELECT')
+        # bpy.context.object.pose.bones[hip_bone_name].bone.select = True        
+        # bpy.context.area.ui_type = 'DOPESHEET'
+        # bpy.context.space_data.dopesheet.filter_text = "Location"
+        # bpy.context.area.ui_type = 'FCURVES'
+        # #COPY THE LOCATION VALUES OF THE HIPS AND DELETE THEM         
+        # bpy.ops.graph.copy()
+        # bpy.ops.graph.select_all(action='DESELECT')
+            
+        # myFcurves = bpy.context.object.animation_data.action.fcurves
+                
+        # for i in myFcurves:
+        #     hip_bone_fcvurve = 'pose.bones["'+hip_bone_name+'"].location'
+        #     if str(i.data_path)==hip_bone_fcvurve:
+        #         myFcurves.remove(i)
+                    
+        # bpy.ops.pose.select_all(action='DESELECT')
+        # bpy.context.object.pose.bones[name_prefix + root_bone_name].bone.select = True
+        # bpy.ops.graph.paste()
+
+        # for animation data in object
+        # for 
+        pass
+
+    for track in bpy.context.object.animation_data.nla_tracks:
+        bpy.context.object.animation_data.nla_tracks.active = track
+        for strip in track.strips:
+            bpy.context.object.pose.bones[name_prefix + root_bone_name].bone.select = True
+            bpy.context.area.ui_type = 'NLA_EDITOR'
+            bpy.ops.nla.tweakmode_enter()
+            bpy.context.area.ui_type = 'FCURVES'
+            hip_curves = [fc for fc in strip.fcurves if hip_bone_name in fc.data_path and fc.data_path.startswith('location')]
+            
+            # Copy Hips to root
+            ## Insert keyframe for root bone
+            start_frame = strip.action.frame_range[0]
+            # frame sets the x axis cursor (determines the frame, and value the y axis cursor, which is the amplitude of the curve)
+            bpy.ops.graph.cursor_set(frame=start_frame, value=0.0)
+            bpy.ops.anim.keyframe_insert_menu(type='Location')
+            bpy.ops.pose.select_all(action='DESELECT')
+
+            ## Copy Location fcruves
+            bpy.context.object.pose.bones[hip_bone_name].bone.select = True        
+            bpy.context.area.ui_type = 'DOPESHEET'
+            bpy.context.space_data.dopesheet.filter_text = "Location"
+            bpy.context.area.ui_type = 'FCURVES'
+            bpy.ops.graph.copy()
+            bpy.ops.graph.select_all(action='DESELECT')
+
+            ## We want to delete the hips locations
+            allFcurves = strip.fcurves
+            for fc in hip_curves:
+                allFcurves.remove(fc)
+
+            ## Paste location fcurves to the root bone
+            bpy.ops.pose.select_all(action='DESELECT')
+            bpy.context.object.pose.bones[name_prefix + root_bone_name].bone.select = True
+            bpy.ops.graph.paste()
+
+
+            loc_fcurves = [fc for fc in strip.fcurves if root_bone_name in fc.data_path and fc.data_path.startswith('location')]
+            
+            # Update Root Bone
+            # set z of root to min 0 (not negative).
+            for fc in loc_fcurves:
+                # Z axis location curve
+                if fc.array_index == 2:
+                    for kp in fc.keyframe_points:
+                        kp.co.z = min(0, abs(kp.co.z))
+                        
+            # Delete rotation curves for x(0) and y(1) axis. Should we delet Z rotation too? 
+            # rot_fcurves = [fc for fc in strip.fcurves if root_bone_name in fc.data_path and fc.data_path.startswith('rotation') and (fc.array_index == 0 or fc.array_index == 1)]
+            # for fc in rot_fcurves:
+            #     strip.fcurves.remove(fc)
+            # while(rot_fcurves):
+            #     fc = rot_fcurves.pop()
+            #     strip.fcurves.remove(fc)
+            bpy.context.area.ui_type = 'NLA_EDITOR'
+            bpy.ops.nla.tweakmode_exit()
+            bpy.context.area.ui_type = previous_context
+    bpy.ops.object.mode_set(mode='OBJECT')
 
 def deleteArmature(imported_objects=set()):
     armature = None
@@ -164,6 +302,21 @@ def add_root_bone(root_bone_name="Root", hip_bone_name="mixamorig:Hips", remove_
     scaleAll()
     copyHips(root_bone_name=root_bone_name, hip_bone_name=hip_bone_name, name_prefix=name_prefix)
 
+def add_root_bone_nla(root_bone_name="Root", hip_bone_name="mixamorig:Hips", name_prefix="mixamorig:"):#remove_prefix=False, name_prefix="mixamorig:"):
+    armature = bpy.context.selected_objects[0]
+    bpy.ops.object.mode_set(mode='EDIT')
+
+    # Add root bone to edit bones
+    root_bone = armature.data.edit_bones.new(name_prefix + root_bone_name)
+    root_bone.tail.z = .25
+
+    armature.data.edit_bones[hip_bone_name].parent = armature.data.edit_bones[name_prefix + root_bone_name]
+    bpy.ops.object.mode_set(mode='OBJECT')
+
+    # fix_bones_nla(remove_prefix=remove_prefix, name_prefix=name_prefix)
+    # scale_all_nla()
+    copy_hips_nla(root_bone_name=root_bone_name, hip_bone_name=hip_bone_name, name_prefix=name_prefix)
+
 def push(obj, action, track_name=None, start_frame=0):
     # Simulate push :
     # * add a track