refactor: clean up the bug fix code, didn't want multiple loops.

Author: RickyBhatti

sv_chat_tags.lua

@@ -21,34 +21,28 @@ local function syncTags(source)
 
     local rolesAllowed = {}
     local highestRole, highestRoleIndex = nil, nil
+    local roles = nil
+
+    if indetifiers.discord then
+        roles = getRoles(source)
+    end
 
     for i = 1, #RoleList do
         if tostring(RoleList[i][1]) == "0" then
             insert(rolesAllowed, i)
             highestRoleIndex = i
         end
-    end
 
-    if not identifiers.discord then -- If the player doesn't have a discord identifier, we'll just assign the default role, if it exists.
-        cachedPlayerRoles[source] = rolesAllowed
-        playerSelectedRole[source] = RoleList[highestRoleIndex][2]
-        return 
-    end
-
-    local roles = getRoles(source)
-    if roles == nil then goto skip end
-
-    for i = 1, #RoleList do 
+        if roles == nil then goto skip end
         for _, v in pairs(roles) do
             if tostring(RoleList[i][1]) == tostring(v) then
                 insert(rolesAllowed, i)
                 highestRole, highestRoleIndex = v, i
             end
         end
+        ::skip::
     end
 
-    ::skip::
-
     cachedPlayerRoles[source] = rolesAllowed
     playerSelectedRole[source] = RoleList[highestRoleIndex][2]
 end