Skip to content

Commit e4ef0f3

Browse files
Updated activity bike summary
1 parent 9cc5860 commit e4ef0f3

3 files changed

Lines changed: 1 addition & 8 deletions

File tree

src/controllers/activities/getActivityCountByBike.ts

Lines changed: 0 additions & 3 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { ActivitySummary } from "../../../models/activitySummary";
22

33
export async function getActivitySummaryByBike(database: D1Database, bikeId: string): Promise<ActivitySummary[]> {
4-
return (await database.prepare("SELECT activity_summary.key, SUM(activity_summary.value) FROM activity_summary INNER JOIN activities ON activities.bike = ? WHERE activity_summary.id = activities.id GROUP BY activity_summary.key").bind(bikeId).all<ActivitySummary>()).results ?? [];
4+
return (await database.prepare("SELECT key, value FROM (SELECT activity_summary.key AS key, SUM(activity_summary.value) AS value FROM activity_summary INNER JOIN activities ON activities.bike = ?1 WHERE activity_summary.id = activities.id GROUP BY activity_summary.key UNION ALL SELECT 'activities' AS key, COUNT(id) AS value FROM activities WHERE bike = ?1)").bind(bikeId).all<ActivitySummary>()).results ?? [];
55
};

src/routes/bikes/index.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { getActivityCountByBike } from "../../controllers/activities/getActivityCountByBike";
21
import { getActivitySummaryByBike } from "../../controllers/activities/summary/getActivitySummaryByBike";
32
import { getBikeById } from "../../controllers/bikes/getBikeById";
43
import { getBikePrimaryImage } from "../../controllers/bikes/images/getBikePrimaryImage";
@@ -21,7 +20,6 @@ export async function handleBikeRequest(request: RequestWithKey, env: Env) {
2120
return Response.json({ success: false });
2221

2322
const bikeSummary = await getActivitySummaryByBike(env.DATABASE, bike.id);
24-
const bikeActivityCount = await getActivityCountByBike(env.DATABASE, bike.id);
2523
const bikeImage = await getBikePrimaryImage(env.DATABASE, bike.id);
2624

2725
return Response.json({
@@ -33,8 +31,6 @@ export async function handleBikeRequest(request: RequestWithKey, env: Env) {
3331
model: bike.model,
3432
image: bikeImage?.image,
3533

36-
activities: bikeActivityCount,
37-
3834
summary: bikeSummary.map((bikeSummary) => {
3935
return {
4036
key: bikeSummary.key,

0 commit comments

Comments
 (0)