Milestone 1: Completed professional portfolio#2
Conversation
Ridwanullahi-code
commented
Aug 20, 2022
Ridwanullahi-code
commented
- Added Header section
- Added Work section
- Added About me section
- Added output folder
- Updated readme file
There was a problem hiding this comment.
Hi @Ridwanullahi-code ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- All linters checks passed
- Correct use of Github flow
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <div class="technologies"> | ||
| <h2>Languages</h2> | ||
| <div> | ||
| <img src="images/Ellipse1.png" alt=""> | ||
| <p>Javascript</p> | ||
| </div> | ||
| <div> | ||
| <img src="images/Ellipse2.png" alt=""> | ||
| <p>HTML</p> | ||
| </div> | ||
| <div> | ||
| <img src="images/Ellipse3.png" alt=""> | ||
| <p>CSS</p> | ||
| </div> | ||
| </div> | ||
| <!-- kist of hard skills --> | ||
| <div class="skills"> | ||
| <div> | ||
| <h2>Frameworks</h2> | ||
| <p>></p> | ||
| </div> | ||
| <hr> | ||
| <div> | ||
| <h2>Skills</h2> | ||
| <p>></p> |
There was a problem hiding this comment.
-
As demanded by the project requirements. Please use
<ul>and<li>for categories in "About myself" section. Languages, Frameworks, and Skills should be list items. -
Please kindly use indentation of two spaces in all your documents. This is a convention and best practice.
| .work-section { | ||
| position: relative; | ||
| top: 90%; | ||
| } | ||
|
|
||
| /* style work section part */ | ||
| .projects { | ||
| margin: 114px auto; | ||
| background-color: white; | ||
| height: 585px; | ||
| width: 327px; | ||
| border: 1px solid #dfe1e6; | ||
| border-radius: 16px; | ||
| } | ||
|
|
There was a problem hiding this comment.
- As demanded by the project requirements. Kindly use grid to lay out your work section and use flexbox to lay out the contents of all your project cards.
| .projects .button, | ||
| .resume-button { | ||
| padding: 12px 20px; | ||
| width: 100px; | ||
| height: 24px; | ||
| font-weight: 500px; | ||
| size: 17px; | ||
| line-height: 48px; | ||
| color: #396df2; | ||
| text-align: center; | ||
| border: 1px solid #396df2; | ||
| border-radius: 8px; | ||
| position: relative; | ||
| top: 25px; | ||
| } |
There was a problem hiding this comment.
-
Kindly add a hover and pressed state to your buttons to match the Figma design template. You can use the
:hoverand:activepseudo-classes. -
[Optional] It's better to follow commit message standards by making them capitalized and in the imperative form (Example: 'Modify readme file' instead of 'modified readme'). This way, your commit history will be more readable and more professional ✨ Kindly check here for more details.
| .about { | ||
| width: 375px; | ||
| height: 1100px; | ||
| background: white; | ||
| border: 1px solid white; | ||
| border-radius: 0 80px 0 0; | ||
| } |
There was a problem hiding this comment.
- Kindly use flexbox to align the contents of the about section as demanded by the project requirement. This is best for the responsiveness of your work.
MaganaAsiati
left a comment
MaganaAsiati
left a comment
There was a problem hiding this comment.
Status: Approved ✔️
Hi @Harrynoqs , I'm @MaganaAsiati , your reviewer for this PR 👋
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- descriptive README file ✔️👨🏻💻
- Your commits should start with a capital letter ✔️👨🏻💻
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
- [OPTIONAL] Please make sure to make your commit messages more descriptive in the future.
- kindly Add a descriptive description in your pull request in the future which give more information about what you implement in this milestone ✔️👨🏻💻
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Cheers and Happy coding!👏👏👏
3 participants
