Skip to content

Commit e4a27c5

Browse files
author
DevMello
committed
refine TODO comments for clarity in MecanumDrive and PinpointLocalizer
1 parent 67a3bb5 commit e4a27c5

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/roadrunner/MecanumDrive.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
public final class MecanumDrive {
5656
public static class Params {
5757
// IMU orientation
58-
// TODO: fill in these values based on
58+
// TODO: fill in these values
5959
// see https://ftc-docs.firstinspires.org/en/latest/programming_resources/imu/imu.html?highlight=imu#physical-hub-mounting
6060
public RevHubOrientationOnRobot.LogoFacingDirection logoFacingDirection =
6161
RevHubOrientationOnRobot.LogoFacingDirection.UP;
@@ -235,7 +235,7 @@ public MecanumDrive(HardwareMap hardwareMap, Pose2d pose) {
235235
rightBack.setZeroPowerBehavior(DcMotor.ZeroPowerBehavior.BRAKE);
236236
rightFront.setZeroPowerBehavior(DcMotor.ZeroPowerBehavior.BRAKE);
237237

238-
// TODO: reverse motor directions if needed
238+
// TODO: reverse motor directions
239239
// leftFront.setDirection(DcMotorSimple.Direction.REVERSE);
240240

241241

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/roadrunner/PinpointLocalizer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,14 @@ public static class Params {
3636
private Pose2d txPinpointRobot = new Pose2d(0, 0, 0);
3737

3838
public PinpointLocalizer(HardwareMap hardwareMap, Pose2d initialPose) {
39-
// TODO: make sure your config has a Pinpoint device with this name
39+
// TODO: make sure your config has a Pinpoint device with this
4040
// see https://ftc-docs.firstinspires.org/en/latest/hardware_and_software_configuration/configuring/index.html
4141
driver = hardwareMap.get(GoBildaPinpointDriver.class, "odo");
4242

4343
driver.setEncoderResolution(PARAMS.res, DistanceUnit.MM);
4444
driver.setOffsets(PARAMS.xOffset, PARAMS.yOffset, DistanceUnit.MM);
4545

46-
// TODO: reverse encoder directions if needed
46+
// TODO: reverse encoder directions
4747
initialParDirection = GoBildaPinpointDriver.EncoderDirection.FORWARD;
4848
initialPerpDirection = GoBildaPinpointDriver.EncoderDirection.FORWARD;
4949

0 commit comments

Comments
 (0)