Add query_hand_ephemeral one-shot hand query#1250
Open
Conversation
Introduce a new KernelHandle method query_hand_ephemeral for synchronous one-shot hand queries that return an LLM response wrapped as external untrusted content (hand://...). Implement the method on OpenFangKernel; it clones the agent manifest, applies a transient max_tokens override, disables tools, calls the resolved LLM driver with a wall-clock timeout, and guarantees no session or persistence side effects. Make default_driver test-swappable by changing it to RwLock<Arc<dyn LlmDriver>> and add a #[cfg(test)] set_test_default_driver helper. Update resolve_driver fallback to read the locked default driver. Add extensive tests and test drivers (RecordingDriver, SleepDriver) to verify wrapping, timeout, max_tokens behavior, and zero-persistence guarantees. Add default trait impl in runtime that returns not supported for backwards compatibility. Signed-off-by: Marcos Alberto Villegas Madrigal <marcosvillegasmadrigal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new KernelHandle method query_hand_ephemeral for synchronous one-shot hand queries that return an LLM response wrapped as external untrusted content (hand://...). Implement the method on OpenFangKernel; it clones the agent manifest, applies a transient max_tokens override, disables tools, calls the resolved LLM driver with a wall-clock timeout, and guarantees no session or persistence side effects. Make default_driver test-swappable by changing it to RwLock<Arc> and add a #[cfg(test)] set_test_default_driver helper. Update resolve_driver fallback to read the locked default driver. Add extensive tests and test drivers (RecordingDriver, SleepDriver) to verify wrapping, timeout, max_tokens behavior, and zero-persistence guarantees. Add default trait impl in runtime that returns not supported for backwards compatibility.
Summary
Changes
Testing
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepassesSecurity