Ripme now counts files as already download (for the history.end_rip_a…#1298
Open
cyian-1756 wants to merge 3 commits intoRipMeApp:mainfrom
Open
Ripme now counts files as already download (for the history.end_rip_a…#1298cyian-1756 wants to merge 3 commits intoRipMeApp:mainfrom
cyian-1756 wants to merge 3 commits intoRipMeApp:mainfrom
Conversation
added 3 commits
May 6, 2019 00:37
…fter_already_seen feature) if they appear on disk and not in the url history file
Collaborator
Author
|
In it's current state this breaks the GUI and should not be merged |
Collaborator
Author
|
This PR is being blocked by the bug first reported in #26. |
Collaborator
Author
|
If anyone else can test this it would be a great help. The issue I've run into is that even tho the GUI reports the rip has ended, it keeps ripping in the background. To test this
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fter_already_seen feature) if they appear on disk and not in the url history file
Category
This change is exactly one of the following (please change
[ ]to[x]) to indicate which:Description
This change allows ripme to count files that exist on disk but were never added to the url history file to be counted as already downloaded.
This allows user to use the history.end_ripe_after_already_seen feature without needing to save a list of all files the user has downloaded
Testing
Required verification:
mvn test(there are no new failures or errors).Optional but recommended: