fix(spans): report in case of missing spans too

Author: gergelyke

lib/agent/api/index.js

@@ -146,7 +146,7 @@ CollectorApi.prototype.sendSamples = function (samples, sync) {
     version: '2',
     instance: this._withInstanceInfo({}),
     service: {
-      key: this.serviceKey,
+      key: this.serviceKey ? this.serviceKey : undefined,
       name: this.serviceName
     }
   }

lib/agent/api/index.spec.js

@@ -99,8 +99,7 @@ describe('The Trace CollectorApi module', function () {
             pid: defaultConfig.system.processId
           },
           service: {
-            name: defaultConfig.serviceName,
-            key: null
+            name: defaultConfig.serviceName
           }
         }, data))
         return JSON.stringify(data)

lib/agent/index.js

@@ -233,15 +233,30 @@ Agent.prototype.clientReceive = function (data) {
 Agent.prototype.onCrash = function (data) {
   var span = this.findSpan(this.getRequestId())
   var parentCommId = this.getParentCommId()
+  var crashWithoutSpan
 
   if (!span) {
-    return
+    // we have a crash which does not belong to an open transaction
+    // creating one
+    crashWithoutSpan = true
+    parentCommId = this.generateCommId()
+
+    span = this.openSpan(this.generateRequestId())
+    span.events.push({
+      type: Agent.SERVER_RECV,
+      time: this.getMicrotime(),
+      data: {
+        method: 'ERROR',
+        endpoint: 'stacktrace',
+        rpcId: parentCommId
+      }
+    })
   }
 
   span.isForceSampled = true
 
   span.events.push({
-    time: microtime.now(),
+    time: this.getMicrotime(),
     type: Agent.ERROR,
     data: {
       rpcId: parentCommId,
@@ -253,6 +268,18 @@ Agent.prototype.onCrash = function (data) {
     }
   })
 
+  if (crashWithoutSpan) {
+    // faking the server send event
+    span.events.push({
+      time: microtime.now(),
+      type: Agent.SERVER_SEND,
+      data: {
+        rpcId: parentCommId,
+        statusCode: 500
+      }
+    })
+  }
+
   this.reservoirSampler.addReturnsSuccess(span)
 
   this._send({

lib/agent/index.spec.js

@@ -96,7 +96,68 @@ describe('The Trace agent', function () {
     })
   })
 
-  it('does server receive when there is no parentServiceId', function () {
+  it('reports crashes', function () {
+    var sendStub = this.sandbox.stub(agent, '_send', function () {})
+    var error = new Error('error')
+    error.stack = 'stacktrace'
+    this.sandbox.stub(agent, 'getMicrotime', function () {
+      return time
+    })
+    this.sandbox.stub(agent, 'generateRequestId', function () {
+      return requestId
+    })
+    this.sandbox.stub(agent, 'generateCommId', function () {
+      return parentCommId
+    })
+
+    agent.onCrash({
+      stackTrace: error
+    })
+
+    expect(agent.reservoirSampler.getItems()).to.eql([
+      {
+        requestId: requestId,
+        isSampled: false,
+        isForceSampled: true,
+        events: [
+          {
+            type: 'sr',
+            time: time,
+            data: {
+              endpoint: 'stacktrace',
+              method: 'ERROR',
+              rpcId: parentCommId
+            }
+          },
+          {
+            type: 'err',
+            time: time,
+            data: {
+              rpcId: parentCommId,
+              type: 'system-error',
+              message: error.message,
+              raw: {
+                stack: error.stack
+              }
+            }
+          },
+          {
+            type: 'ss',
+            time: time,
+            data: {
+              rpcId: parentCommId,
+              statusCode: 500
+            }
+          }
+        ]
+      }
+    ])
+    expect(sendStub).to.be.calledWith({
+      isSync: true
+    })
+  })
+
+  it('does server receive when there is no parentId', function () {
     agent.serverReceive({
       requestId: requestId,
       parentCommId: parentCommId,