feat(configReader): add HTTP_PROXY

Author: dszakallas

lib/utils/configReader.js

@@ -63,7 +63,7 @@ ConfigReader.prototype._getEnvVarConfig = function () {
     disableInstrumentations: process.env.TRACE_DISABLE_INSTRUMENTATIONS
       ? process.env.TRACE_DISABLE_INSTRUMENTATIONS.split(',')
       : undefined,
-    proxy: process.env.TRACE_PROXY
+    proxy: process.env.TRACE_PROXY || process.env.HTTP_PROXY
   }
 
   var ignoreHeaders

lib/utils/configReader.spec.js

@@ -331,7 +331,7 @@ describe('Config Reader module', function () {
     var configReader = ConfigReader.create({
       apiKey: 'test',
       reporter: 'dummy',
-      configPath: 'test'
+      serviceName: 'test'
     })
 
     try {
@@ -345,6 +345,39 @@ describe('Config Reader module', function () {
   })
 
   describe('config variable', function () {
+    describe('traceProxy', function () {
+      it('should be configurable with the HTTP_PROXY env var', function () {
+        this.sandbox.stub(process, 'env', {
+          HTTP_PROXY: 'http://proxy.com'
+        })
+
+        var configReader = ConfigReader.create({
+          apiKey: testApiToken,
+          reporter: 'dummy',
+          serviceName: 'test'
+        })
+
+        var config = configReader.getConfig()
+
+        expect(config.proxy).to.equal('http://proxy.com')
+      })
+      it('TRACE_PROXY env var takes precedence over HTTP_PROXY', function () {
+        this.sandbox.stub(process, 'env', {
+          TRACE_PROXY: 'http://trace-proxy.com',
+          HTTP_PROXY: 'http://proxy.com'
+        })
+
+        var configReader = ConfigReader.create({
+          apiKey: testApiToken,
+          reporter: 'dummy',
+          serviceName: 'test'
+        })
+
+        var config = configReader.getConfig()
+
+        expect(config.proxy).to.equal('http://trace-proxy.com')
+      })
+    })
     describe('disableInstrumentations', function () {
       it('defaults to []', function () {
         var configReader = ConfigReader.create({