fix(metrics): fix serviceKey check for metrics

gergelyke · gergelyke · commit d0dbb4675ba1 · 2016-05-22T21:08:46.000+02:00
diff --git a/lib/agent/api/index.js b/lib/agent/api/index.js
@@ -107,7 +107,7 @@ CollectorApi.prototype.sendApmMetrics = function (data) {
 }
 
 CollectorApi.prototype.sendExternalEdgeMetrics = function (data) {
-  if (isNaN(this.serviceKey)) {
+  if (!isNumber(this.serviceKey)) {
     debug('Service id not present, cannot send metrics')
     return
   }
@@ -117,7 +117,7 @@ CollectorApi.prototype.sendExternalEdgeMetrics = function (data) {
 }
 
 CollectorApi.prototype.sendIncomingEdgeMetrics = function (data) {
-  if (isNaN(this.serviceKey)) {
+  if (!isNumber(this.serviceKey)) {
     debug('Service id not present, cannot send metrics')
     return
   }

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ CollectorApi.prototype.sendApmMetrics = function (data) {`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`CollectorApi.prototype.sendExternalEdgeMetrics = function (data) {`
`110`		`- if (isNaN(this.serviceKey)) {`
	`110`	`+ if (!isNumber(this.serviceKey)) {`
`111`	`111`	`debug('Service id not present, cannot send metrics')`
`112`	`112`	`return`
`113`	`113`	`}`
`@@ -117,7 +117,7 @@ CollectorApi.prototype.sendExternalEdgeMetrics = function (data) {`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`CollectorApi.prototype.sendIncomingEdgeMetrics = function (data) {`
`120`		`- if (isNaN(this.serviceKey)) {`
	`120`	`+ if (!isNumber(this.serviceKey)) {`
`121`	`121`	`debug('Service id not present, cannot send metrics')`
`122`	`122`	`return`
`123`	`123`	`}`