Skip to content

Commit bfc1c53

Browse files
cleaning and standeardization custoemr table and handling datyaissues
Co-authored-by: ritsky-project <ritsky598@gmail.com>
1 parent 4bd1200 commit bfc1c53

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

explore_database/returns/return.sql

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,9 @@ WITH cleaned_txn_ids AS
8383
(
8484
SELECT
8585
CASE
86-
WHEN original_txn_id IS NULL OR original_txn_id NOT LIKE 'TXN-%' OR LEN(original_txn_id) < 10 THEN NULL
86+
WHEN original_txn_id IS NULL THEN NULL
87+
WHEN UPPER(TRIM(original_txn_id)) NOT LIKE 'TXN-%' THEN NULL
88+
WHEN LEN(UPPER(TRIM(original_txn_id))) < 10 THEN NULL
8789
ELSE UPPER(TRIM(original_txn_id))
8890
END as original_txn_id
8991
FROM bronze.[returns]
@@ -180,7 +182,7 @@ WITH cleaned_customer_names AS
180182
(
181183
SELECT
182184
CASE
183-
WHEN customer_name IS NULL OR customer_name != TRIM(dbo.TitleCase(customer_name)) OR LEN(customer_name) < 3 THEN 'Unknown'
185+
WHEN customer_name IS NULL OR TRIM(customer_name) = '' THEN 'Unknown'
184186
ELSE dbo.TitleCase(TRIM(customer_name))
185187
END as customer_name
186188
FROM bronze.[returns]
@@ -235,17 +237,19 @@ FROM
235237
(
236238
SELECT
237239
CASE
238-
WHEN return_id < 1 OR TRY_CONVERT(INT, return_id) IS NULL THEN NULL
240+
WHEN TRY_CONVERT(INT, return_id) < 1 OR TRY_CONVERT(INT, return_id) IS NULL THEN NULL
239241
ELSE TRY_CONVERT(INT, return_id)
240242
END as return_id
241243

242244
,CASE
243-
WHEN original_txn_id IS NULL OR original_txn_id NOT LIKE 'TXN-%' OR LEN(original_txn_id) < 10 THEN NULL
245+
WHEN original_txn_id IS NULL THEN NULL
246+
WHEN UPPER(TRIM(original_txn_id)) NOT LIKE 'TXN-%' THEN NULL
247+
WHEN LEN(UPPER(TRIM(original_txn_id))) < 10 THEN NULL
244248
ELSE UPPER(TRIM(original_txn_id))
245249
END as original_txn_id
246250

247251
,CASE
248-
WHEN original_order_id IS NULL OR TRY_CONVERT(INT, original_order_id) IS NULL THEN NULL
252+
WHEN original_order_id IS NULL OR TRY_CONVERT(INT, original_order_id) < 1 OR TRY_CONVERT(INT, original_order_id) IS NULL THEN NULL
249253
ELSE TRY_CONVERT(INT, original_order_id)
250254
END as original_order_id
251255

@@ -255,7 +259,7 @@ FROM
255259
END as customer_id
256260

257261
,CASE
258-
WHEN customer_name IS NULL OR customer_name != TRIM(dbo.TitleCase(customer_name)) OR LEN(customer_name) < 3 THEN 'Unknown'
262+
WHEN customer_name IS NULL OR TRIM(customer_name) = '' THEN 'Unknown'
259263
ELSE dbo.TitleCase(TRIM(customer_name))
260264
END as customer_name
261265

0 commit comments

Comments
 (0)