roaring64: Use roaring.ParOr when all keys on the roaringArray64 are same#476
Merged
lemire merged 1 commit intoRoaringBitmap:masterfrom Jun 28, 2025
Merged
Conversation
ofpiyush
changed the title
Member
|
Running tests. Seems reasonable. |
Contributor
Author
|
The tests pass. Is it good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd love to use the 64-bit variant to keep the implementation consistent across various use cases.
The merge performance of
roaring64.ParOrsuffers when all the bitmaps share the same upper 32 bits.PS: I believe this behavior is correct. If it's not, let me know 😇