Skip to content

Run tests and PHPStan on PHP 8.5#1515

Merged
Ocramius merged 1 commit into
Roave:6.60.xfrom
kukulich:php85
Aug 21, 2025
Merged

Run tests and PHPStan on PHP 8.5#1515
Ocramius merged 1 commit into
Roave:6.60.xfrom
kukulich:php85

Conversation

@kukulich

@kukulich kukulich commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

Psalm is now broken because of this: php/php-src#19424

@kukulich kukulich changed the title Run tests on static analysis on PHP 8.5 Run tests and static analysis on PHP 8.5 Aug 4, 2025
@kukulich kukulich force-pushed the php85 branch 4 times, most recently from ee24e7f to 97c1402 Compare August 5, 2025 18:31
@kukulich kukulich force-pushed the php85 branch 2 times, most recently from 7fbc517 to 74982d6 Compare August 20, 2025 18:52
@kukulich kukulich changed the title Run tests and static analysis on PHP 8.5 Run tests and PHPStan on PHP 8.5 Aug 20, 2025
@kukulich kukulich marked this pull request as ready for review August 20, 2025 19:05

@Ocramius Ocramius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread .github/workflows/continuous-integration.yml
Comment thread test/unit/Fixture/PHP85ClassForSourceStubber.php Outdated
Comment thread test/unit/SourceLocator/SourceStubber/PhpStormStubsSourceStubberTest.php Outdated
Comment thread test/unit/SourceLocator/SourceStubber/PhpStormStubsSourceStubberTest.php Outdated
Comment thread test/unit/SourceLocator/SourceStubber/PhpStormStubsSourceStubberTest.php Outdated
Comment thread test/unit/SourceLocator/SourceStubber/PhpStormStubsSourceStubberTest.php Outdated
Comment thread test/unit/SourceLocator/SourceStubber/PhpStormStubsSourceStubberTest.php Outdated

@Ocramius Ocramius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Ocramius Ocramius self-assigned this Aug 21, 2025
@Ocramius Ocramius added enhancement reflection compatibility dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Aug 21, 2025
@Ocramius Ocramius added this to the 6.60.0 milestone Aug 21, 2025
@Ocramius Ocramius merged commit 53dd017 into Roave:6.60.x Aug 21, 2025
37 checks passed
@kukulich

Copy link
Copy Markdown
Collaborator Author

@Ocramius Btw it looks renovate is broken again.

@Ocramius

Copy link
Copy Markdown
Member

@kukulich any details on what broke?

@kukulich

Copy link
Copy Markdown
Collaborator Author

@Ocramius

Copy link
Copy Markdown
Member

@kukulich I think it's because of roave/infection-static-analysis-plugin locking it in place. I haven't touched roave/infection-static-analysis-plugin in a while: that should allow an upgrade again.

Renovate will always struggle to upgrade them separately

@kukulich

Copy link
Copy Markdown
Collaborator Author

Oh, ok 👍

@Ocramius

Copy link
Copy Markdown
Member

I released 1.39.0 of roave/infection-static-analysis-plugin, meanwhile: infection/infection has been rolled back for now, and will be upgraded separately in that package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement php Pull requests that update Php code reflection compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants