fix(self-check): preserve custom task routing#1
Merged
RobGeada merged 8 commits intoJun 26, 2026
Merged
Conversation
Strip section-divider, inline, and numbered-step comments added to the new multiple-self-check-rails test file to comply with the no-comments convention. Behavior is unchanged; all 30 tests still pass.
The tail of resolve_self_check_task was only reachable when task is falsy or $-prefixed, so both branches always returned default_task. Collapse them into a single return default_task.
Pouyanpi
force-pushed
the
pr-1874-first-class-self-check-tasks
branch
from
0139dc4 to
2895b99
Compare
RobGeada
approved these changes
Jun 26, 2026
| default_task=DEFAULT_TASK, | ||
| main_llm=llm, | ||
| llm_task_manager=llm_task_manager, | ||
| lowest_temperature=config.lowest_temperature, |
Owner
There was a problem hiding this comment.
lowest_temperature=config.lowest_temperature
This is probably better suited for a separate PR, but I think should be this configurable from the task, not from a global config setting
Author
There was a problem hiding this comment.
This is pre-existing, see https://github.com/RobGeada/NeMo-Guardrails/pull/1/changes#r3480276378 . I don't have full context right now but seems hacky. I'll create an issue to track this
Pouyanpi
commented
Jun 26, 2026
| prompt, | ||
| stop=stop, | ||
| llm_params={ | ||
| "temperature": config.lowest_temperature, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to NVIDIA-NeMo#1874 with targeted fixes for the custom self-check task routing regressions.
What changed:
Validation: