This repository was archived by the owner on Apr 15, 2025. It is now read-only.
fix(config): read using utf-8#1002
Open
AmaseCocoa wants to merge 9 commits into
Open
Conversation
RobertCraigie
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR!
It'd be great if you could add a unit test for this case to tests/test_config.py. We have some existing tests for config loading there which you can take inspiration from :)
for more information, see https://pre-commit.ci
Author
|
Added Unit Test ( |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Changed
path.read_textto explicitly use utf-8 to avoidUnicodeEncodeErrorthat may be caused by cp932 in Japanese Windows environments.src/prisma/_config.pyandtests/test_config.pywas changed.(This is my first time contributing to another repository, so there may be some clumsiness, but I'd appreciate it if you could let me know if that's the case.)
Checklist
Agreement
By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.