Migrating to tsdown (#2889)

Due to egoist/tsup#1332

Migration guide: https://tsdown.dev/guide/migrate-from-tsup

Findings:
- removes augmentation from DTS if it's not a `.d.ts` file — ~~addressed
by renaming~~ addressed using banner and extra entrypoint
- does not support imports without extension in config file
- does not support importing JSON files without import attributes in
config file — addressed by `readFile`
- surprisingly keeps the import of a runtime dependency in DTS even if
unused (had to patch tsup for that)
- dts, cleanup and node protocol — are by default
- `attw` is integrated when installed

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Chores**
* Switched the project to a new build tool and added corresponding build
configurations; removed legacy bundler configs, patches, and related
build scripts; bumped package versions and cleaned build-related
dependencies.
* **Tests**
* Updated tests for the new build tooling and added DTS compatibility
checks for TypeScript declarations.
* **Notes**
  * No user-facing API or runtime behavior changes expected.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: RobinTail

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Version 25
 
+### v25.3.0
+
+- Changed bundler from `tsup` to `tsdown`.
+
 ### v25.2.0
 
 - Zod Plugin extracted into a standalone package — `@express-zod-api/zod-plugin`:

compat-test/dts.spec.ts

@@ -0,0 +1,28 @@
+import { describe, test, expect } from "vitest";
+import { readFile } from "node:fs/promises";
+
+describe("DTS", () => {
+  test("Framework must import Zod plugin", async () => {
+    const fwDts = await readFile(
+      "./node_modules/express-zod-api/dist/index.d.ts",
+      "utf-8",
+    );
+    expect(fwDts).toMatch(`import "@express-zod-api/zod-plugin";`);
+  });
+
+  test("Zod plugin must import augmentation", async () => {
+    const pluginDts = await readFile(
+      "./node_modules/express-zod-api/node_modules/@express-zod-api/zod-plugin/dist/index.d.ts",
+      "utf-8",
+    );
+    expect(pluginDts).toMatch(`import './augmentation.js';`);
+  });
+
+  test("Augmentation must extend Zod", async () => {
+    const augDts = await readFile(
+      "./node_modules/express-zod-api/node_modules/@express-zod-api/zod-plugin/dist/augmentation.d.ts",
+      "utf-8",
+    );
+    expect(augDts).toMatch(`declare module "zod"`);
+  });
+});

express-zod-api/package.json

@@ -1,6 +1,6 @@
 {
   "name": "express-zod-api",
-  "version": "25.2.0",
+  "version": "25.3.0-beta.1",
   "description": "A Typescript framework to help you get an API server up and running with I/O schema validation and custom middlewares in minutes.",
   "license": "MIT",
   "repository": {
@@ -16,8 +16,7 @@
   "bugs": "https://github.com/RobinTail/express-zod-api/issues",
   "funding": "https://github.com/sponsors/RobinTail",
   "scripts": {
-    "build": "tsup",
-    "postbuild": "attw --pack --profile esm-only",
+    "build": "tsdown",
     "pretest": "tsc --noEmit",
     "test": "vitest run --coverage",
     "bench": "vitest bench --run ./bench",
@@ -90,7 +89,6 @@
     "@types/http-errors": "catalog:dev",
     "@types/node-forge": "^1.3.11",
     "@types/ramda": "catalog:dev",
-    "@types/semver": "^7.7.0",
     "camelize-ts": "catalog:dev",
     "compression": "catalog:dev",
     "cors": "^2.8.5",
@@ -99,7 +97,6 @@
     "express-fileupload": "catalog:dev",
     "http-errors": "catalog:dev",
     "node-forge": "^1.3.1",
-    "semver": "^7.7.2",
     "snakify-ts": "^2.3.0",
     "typescript": "catalog:dev",
     "undici": "^7.10.0",

express-zod-api/src/common-helpers.ts

@@ -139,7 +139,7 @@ export const isObject = (subject: unknown) =>
   typeof subject === "object" && subject !== null;
 
 export const isProduction = R.memoizeWith(
-  () => process.env.TSUP_STATIC as string, // eslint-disable-line no-restricted-syntax -- substituted by TSUP
+  () => process.env.TSDOWN_STATIC as string, // eslint-disable-line no-restricted-syntax -- substituted by TSDOWN
   () => process.env.NODE_ENV === "production", // eslint-disable-line no-restricted-syntax -- memoized
 );
 

express-zod-api/src/server.ts

@@ -32,7 +32,7 @@ const makeCommonEntities = (config: CommonConfig) => {
     ? config.logger
     : new BuiltinLogger(config.logger);
   logger.debug("Running", {
-    build: process.env.TSUP_BUILD || "from sources", // eslint-disable-line no-restricted-syntax -- substituted by TSUP
+    build: process.env.TSDOWN_BUILD || "from sources", // eslint-disable-line no-restricted-syntax -- substituted by TSDOWN
     env: process.env.NODE_ENV || "development", // eslint-disable-line no-restricted-syntax -- intentionally for debug
   });
   installDeprecationListener(logger);

express-zod-api/tests/builtin-logger.spec.ts

@@ -43,7 +43,7 @@ describe("BuiltinLogger", () => {
     test.each(["development", "production"])(
       "Level can be omitted and depends on env",
       (mode) => {
-        vi.stubEnv("TSUP_STATIC", mode);
+        vi.stubEnv("TSDOWN_STATIC", mode);
         vi.stubEnv("NODE_ENV", mode);
         const { logger } = makeLogger();
         expect(logger["config"]["level"]).toBe(

express-zod-api/tests/last-resort.spec.ts

@@ -10,7 +10,7 @@ describe("Last Resort Handler", () => {
 
   describe.each(["development", "production"])("%s mode", (mode) => {
     beforeAll(() => {
-      vi.stubEnv("TSUP_STATIC", mode);
+      vi.stubEnv("TSDOWN_STATIC", mode);
       vi.stubEnv("NODE_ENV", mode);
     });
     afterAll(() => vi.unstubAllEnvs());

express-zod-api/tests/result-helpers.spec.ts

@@ -116,7 +116,7 @@ describe("Result helpers", () => {
     "getPublicErrorMessage() in %s mode",
     (mode) => {
       beforeAll(() => {
-        vi.stubEnv("TSUP_STATIC", mode);
+        vi.stubEnv("TSDOWN_STATIC", mode);
         vi.stubEnv("NODE_ENV", mode);
       });
       afterAll(() => vi.unstubAllEnvs());

express-zod-api/tests/system.spec.ts

@@ -18,7 +18,7 @@ import { givePort } from "../../tools/ports";
 import { setTimeout } from "node:timers/promises";
 
 describe("App in production mode", async () => {
-  vi.stubEnv("TSUP_STATIC", "production");
+  vi.stubEnv("TSDOWN_STATIC", "production");
   vi.stubEnv("NODE_ENV", "production");
   const port = givePort();
   const logger = new BuiltinLogger({ level: "silent" });

express-zod-api/tsdown.config.ts

@@ -0,0 +1,14 @@
+import { defineConfig } from "tsdown";
+import { readFile } from "node:fs/promises";
+
+const { version } = JSON.parse(await readFile("./package.json", "utf8"));
+
+export default defineConfig({
+  entry: "src/index.ts",
+  minify: true,
+  attw: { profile: "esmOnly", level: "error" },
+  define: {
+    "process.env.TSDOWN_BUILD": `"v${version}"`, // @since v25.0.0 is pure ESM
+    "process.env.TSDOWN_STATIC": `"static"`, // used by isProduction()
+  },
+});