chore: Moving DTS tool#3264
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRemoved the standalone Changes
Sequence Diagram(s)(Skipped — changes are configuration and export/import rearrangements without a new multi-component control-flow requiring visualization.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
This is a clean and well-executed refactoring. The dts-plugin workspace is moved to tools/readableDts.ts, which aligns with the existing tools/ directory containing utility scripts.
Key changes:
- Changed from default export to named export (
humanReadableDtsPlugin) - Added
--config-loader unrunflag to tsdown builds (required for loading TypeScript config files in Node.js without file extensions) - Removed the workspace and its dependency references
- Removed the redundant build step from npm-publish workflow (each package handles this via
prepublishOnly) - Added
rolldowntopublicHoistPatternsince the tool uses its types
No issues found.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pnpm-workspace.yaml`:
- Line 47: Update the inline comment string that currently reads "reabdableDts"
to the correct spelling "readableDts" in the pnpm-workspace.yaml entry
containing the "rolldown" item; locate the line containing the literal
"rolldown" and replace the comment text "# used by reabdableDts tool" with "#
used by readableDts tool" so the tooling reference is spelled correctly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0f215ba6-a4be-42ea-b00e-fdd0c9dbbb1f
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (11)
.github/workflows/npm-publish.ymldts-plugin/package.jsondts-plugin/tsconfig.jsonexpress-zod-api/package.jsonexpress-zod-api/tsdown.config.tsmigration/package.jsonmigration/tsdown.config.tspnpm-workspace.yamltools/readableDts.tszod-plugin/package.jsonzod-plugin/tsdown.config.ts
💤 Files with no reviewable changes (3)
- dts-plugin/package.json
- .github/workflows/npm-publish.yml
- dts-plugin/tsconfig.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

From workspace to a tool.
That however requires config loader, because using no file extensions.
Nevertheless, this setup is simpler.
Summary by CodeRabbit