Skip to content

chore: Moving DTS tool#3264

Merged
RobinTail merged 3 commits into
masterfrom
mv-dts-tool
Mar 17, 2026
Merged

chore: Moving DTS tool#3264
RobinTail merged 3 commits into
masterfrom
mv-dts-tool

Conversation

@RobinTail

@RobinTail RobinTail commented Mar 17, 2026

Copy link
Copy Markdown
Owner

From workspace to a tool.
That however requires config loader, because using no file extensions.
Nevertheless, this setup is simpler.

Summary by CodeRabbit

  • Chores
    • Publish pipeline no longer runs a project build step; it now installs dependencies and publishes.
    • Removed the standalone dts-plugin package and replaced it with equivalent local tooling.
    • Updated build commands across packages to include a new config-loader option.
    • Adjusted workspace package listings and hoisting to match the new tooling setup.

@coderabbitai

coderabbitai Bot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cec78c0c-5b7a-436c-bbe5-646753e8ea85

📥 Commits

Reviewing files that changed from the base of the PR and between 6b5dc02 and 9638161.

📒 Files selected for processing (1)
  • express-zod-api/package.json

📝 Walkthrough

Walkthrough

Removed the standalone dts-plugin package and moved its implementation to tools/readableDts.ts as a named export; tsdown configs now import that named plugin. Build scripts were updated to tsdown --config-loader unrun, pnpm workspace entries adjusted, and the npm-publish CI build step removed.

Changes

Cohort / File(s) Summary
CI Workflow
.github/workflows/npm-publish.yml
Removed explicit project build step; workflow now installs dependencies and publishes without running build.
Removed Package Files
dts-plugin/package.json, dts-plugin/tsconfig.json
Deleted the dts-plugin package manifest and TS project config, removing the standalone package.
Build Script Manifests
express-zod-api/package.json, migration/package.json, zod-plugin/package.json
Updated build scripts to tsdown --config-loader unrun and removed dts-plugin from devDependencies/dependencies.
tsdown Configs
express-zod-api/tsdown.config.ts, migration/tsdown.config.ts, zod-plugin/tsdown.config.ts
Replaced default import from dts-plugin with named import humanReadableDtsPlugin from ../tools/readableDts.
Workspace Manifest
pnpm-workspace.yaml
Removed dts-plugin from packages and added "rolldown" to publicHoistPattern.
Tools Module
tools/readableDts.ts
Converted default export to named export: export const humanReadableDtsPlugin = (): Plugin => ..., exposing the plugin as a named export.

Sequence Diagram(s)

(Skipped — changes are configuration and export/import rearrangements without a new multi-component control-flow requiring visualization.)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

dependencies

Poem

🐰 I hopped through folders, swift and bright,
Pulled a plugin home and set it right,
CI lost a step, builds took a breeze,
Workspace neat now — fewer mysteries,
A carrot cheer for tidy bytes! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: Moving DTS tool' directly and clearly describes the main objective of the changeset: relocating the DTS tool from a workspace package to a dedicated tool location.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mv-dts-tool
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clean and well-executed refactoring. The dts-plugin workspace is moved to tools/readableDts.ts, which aligns with the existing tools/ directory containing utility scripts.

Key changes:

  • Changed from default export to named export (humanReadableDtsPlugin)
  • Added --config-loader unrun flag to tsdown builds (required for loading TypeScript config files in Node.js without file extensions)
  • Removed the workspace and its dependency references
  • Removed the redundant build step from npm-publish workflow (each package handles this via prepublishOnly)
  • Added rolldown to publicHoistPattern since the tool uses its types

No issues found.

Pullfrog  | View workflow runpullfrog.com𝕏

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Mar 17, 2026
@coveralls-official

coveralls-official Bot commented Mar 17, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same
when pulling 6b5dc02 on mv-dts-tool
into 97c8d1d on master.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pnpm-workspace.yaml`:
- Line 47: Update the inline comment string that currently reads "reabdableDts"
to the correct spelling "readableDts" in the pnpm-workspace.yaml entry
containing the "rolldown" item; locate the line containing the literal
"rolldown" and replace the comment text "# used by reabdableDts tool" with "#
used by readableDts tool" so the tooling reference is spelled correctly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0f215ba6-a4be-42ea-b00e-fdd0c9dbbb1f

📥 Commits

Reviewing files that changed from the base of the PR and between 97c8d1d and c60e277.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (11)
  • .github/workflows/npm-publish.yml
  • dts-plugin/package.json
  • dts-plugin/tsconfig.json
  • express-zod-api/package.json
  • express-zod-api/tsdown.config.ts
  • migration/package.json
  • migration/tsdown.config.ts
  • pnpm-workspace.yaml
  • tools/readableDts.ts
  • zod-plugin/package.json
  • zod-plugin/tsdown.config.ts
💤 Files with no reviewable changes (3)
  • dts-plugin/package.json
  • .github/workflows/npm-publish.yml
  • dts-plugin/tsconfig.json

Comment thread pnpm-workspace.yaml Outdated
RobinTail and others added 2 commits March 17, 2026 06:14
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@RobinTail
RobinTail merged commit 60ead3d into master Mar 17, 2026
6 checks passed
@RobinTail
RobinTail deleted the mv-dts-tool branch March 17, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD refactoring The better way to achieve the same result

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant