chore(test): Add Integration compatibility test#3391
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdded a Vitest integration compatibility test that instantiates ChangesIntegration Compatibility Test
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
TL;DR — Extends the compat-test/ workspace with a smoke test that exercises Integration.create().print() against the workspace-pinned minimum-supported typescript@5.1.3. Sound scope, sound assertion; only a trailing-newline nit.
Key changes
- Add
Integrationsmoke test against minimum-supported peer TypeScript — newcompat-test/int.spec.tscallsIntegration.create({ config: { cors: false }, routing: {} })and asserts the printed output containsexport class Client, exercising theloadPeer("typescript")path undertypescript@5.1.3.
Summary | 1 file | 1 commit | base: master ← int-compatibility-test
Minimum-TS peer compatibility coverage for Integration
Before:
compat-test/covered DTS shape, migration rules, and quick-start runtime, but not theIntegrationgenerator.
After: A focused spec drivesIntegration.create().print()end-to-end, ensuring the TS factory + printer pipeline works against the pinnedtypescript@5.1.3.
The assertion toContain("export class Client") is anchored on documented public defaults (clientClassName="Client", variant="client"); makeClientClass in integration-base.ts even illustrates the emitted form via @example export class Client { ___ }, so the substring is a stable contract. routing: {} deliberately keeps the test fast — per-endpoint generators (zodToTs etc.) aren't exercised, but the global generators and the printer are, which is the right scope for a peer-version smoke test.
Claude Opus | 𝕏

Summary by CodeRabbit