Skip to content

exp: intake contract for ResultHandler#3407

Draft
RobinTail wants to merge 6 commits into
masterfrom
rh-intake-contract
Draft

exp: intake contract for ResultHandler#3407
RobinTail wants to merge 6 commits into
masterfrom
rh-intake-contract

Conversation

@RobinTail
Copy link
Copy Markdown
Owner

@RobinTail RobinTail commented May 20, 2026

Exploring the DX trade-off between the requirement for ResultHandler to handle any object-based output coming from Endpoints, or giving an ability to enforce type-only contract between ResultHandler and Endpoint through EndpointsFactory.

The POC looks promising except the EndpointsFactory::buildVoid() method that stands out of the concept.

The risk of possible temptation to abuse the type-only contract and remove runtime checks completely may compromise the stability of final products. Therefore, it's still under consideration.

@RobinTail RobinTail added enhancement New feature or request miracle Mysterious events are happening here labels May 20, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: af36e0ac-eefb-438a-9337-63b1f081aab4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rh-intake-contract

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls-official
Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same — rh-intake-contract into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request miracle Mysterious events are happening here

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant