Conversation
RobinTail
added
enhancement
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
coverage: 100.0%. remained the same — use-oas32 into master |
RobinTail
commented
Jun 4, 2026
RobinTail
commented
Jun 4, 2026
# Conflicts: # example/example.documentation.yaml # express-zod-api/src/documentation-helpers.ts # express-zod-api/tests/__snapshots__/documentation-helpers.spec.ts.snap # express-zod-api/tests/__snapshots__/documentation.spec.ts.snap
RobinTail
added a commit
that referenced
this pull request
Jun 5, 2026
…helper (#3442) to operate Zod's JSON schema and assert OAS afterwards. A type-only refactoring to simplify moving further into #3437 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Strengthened the documentation generation system with enhanced type safety mechanisms. Expanded schema type support to accommodate a broader range of definitions while ensuring validation accuracy. Optimized the internal schema processing workflow for improved system flexibility and maintainability. * **Tests** * Updated the test suite to align with the new schema type specifications and enhanced documentation generation capabilities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
# Conflicts: # express-zod-api/src/documentation-helpers.ts
…o OAS 3.2 specification.
…iority by shorthands.
RobinTail
commented
Jun 6, 2026
# Conflicts: # express-zod-api/src/documentation.ts
Owner
Author
RobinTail
added a commit
that referenced
this pull request
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Swagger validator still fails to check OAS 3.2, but the editor already supports it.
Boolean schemas are not yet supported by Zod, so I'm not allowing them in
brandHandlingyet.Since 3.2 is not yet widely supported, I'm gonna consider it a breaking change.