-
-
Notifications
You must be signed in to change notification settings - Fork 38
feat(mw): Rate limit #3463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(mw): Rate limit #3463
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
45e86c6
feat(deps): Add express-rate-limit optional peer and dev dependency.
RobinTail f67ef80
feat(mw): Draft implementation.
RobinTail 0b9683e
Merge branch 'master' into feat-rate-limit
RobinTail 9e2474b
fix(mw): making it sync and simpler typed.
RobinTail 76a4ae7
feat(api): Add EndpointsFactory::useRateLimit() shorthand.
RobinTail 8992be1
feat(test): Testing the new function.
RobinTail 2411418
feat(test): Testing shorthand.
RobinTail 8a5d26c
fix(test): rm local mock.
RobinTail 6639b35
fix: add jsdoc.
RobinTail 5c39492
fix(type): simpler typing.
RobinTail b3d7944
fix(mw): Respecting requestPropertyName option.
RobinTail 6dcfd54
ref: naming.
RobinTail ff2d145
Add limiter API to the provided context.
RobinTail 9f28809
Readme and Changelog updates.
RobinTail a7984ce
Merge branch 'master' into feat-rate-limit
RobinTail 4d76a96
Add example and its tests.
RobinTail 9f16980
changelog: fix punctuation.
RobinTail File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import createHttpError from "http-errors"; | ||
| import type { | ||
| Options, | ||
| AugmentedRequest, | ||
| rateLimit as RateLimitFn, | ||
| RateLimitInfo, | ||
| RateLimitRequestHandler, | ||
| } from "express-rate-limit"; | ||
| import { ExpressMiddleware } from "./middleware"; | ||
| import { loadPeer } from "./peer-helpers"; | ||
|
|
||
| /** | ||
| * @desc Creates an ExpressMiddleware that enforces rate limits using express-rate-limit. | ||
| * @requires express-rate-limit | ||
| * @param options — Partial options passed to the express-rate-limit constructor. | ||
| * @example createRateLimitMiddleware({ windowMs: 60000, max: 100 }) | ||
| */ | ||
| export const createRateLimitMiddleware = (options?: Partial<Options>) => { | ||
| const rateLimit = loadPeer<typeof RateLimitFn>("express-rate-limit"); | ||
| const limiter = rateLimit({ | ||
| ...options, | ||
| handler: (_req, _res, next, optionsUsed) => { | ||
| next(createHttpError(429, optionsUsed.message)); | ||
| }, | ||
| }); | ||
| const { getKey, resetKey } = limiter; | ||
| const limiterApi: Pick<RateLimitRequestHandler, "getKey" | "resetKey"> = { | ||
| getKey, | ||
| resetKey, | ||
| }; | ||
| return new ExpressMiddleware(limiter, { | ||
| provider: (req: AugmentedRequest) => ({ | ||
| rateLimit: { | ||
| ...limiterApi, | ||
| ...req[options?.requestPropertyName ?? "rateLimit"], | ||
| } as RateLimitInfo & typeof limiterApi, | ||
| }), | ||
| }); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.