Upgrade line test functionality#2509
Merged
Merged
Conversation
automated style fixes Co-authored-by: yuvrajdhadwal <yuvrajdhadwal@users.noreply.github.com>
shourikb
reviewed
Mar 8, 2026
shourikb
requested changes
Mar 8, 2026
| rj_geometry::Point end{msg->pt[1].x, msg->pt[1].y}; | ||
| uint8_t r_id{msg->r_id}; | ||
|
|
||
| if (start[0] != start_[0] || start[1] != start_[1] || end[0] != start_[0] || |
Contributor
There was a problem hiding this comment.
shouldn't this be end[0] != end_[0]?
shourikb
approved these changes
Mar 9, 2026
automated style fixes Co-authored-by: yuvrajdhadwal <yuvrajdhadwal@users.noreply.github.com>
CameronLyon
approved these changes
Mar 9, 2026
CameronLyon
left a comment
CameronLyon
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall 👍
rishiso
requested changes
Mar 9, 2026
rishiso
left a comment
rishiso
left a comment
Contributor
There was a problem hiding this comment.
more to come after you add bounds checking
| } | ||
|
|
||
| if (vertical_) { | ||
| if (robot_id_ == target_rid_) { |
Contributor
There was a problem hiding this comment.
Nit: Change this to if (robot_id_ != target_rid_) continue;
There is so much indentation and it looks bad
…m/RoboJackets/robocup-software into upgrade_line_test_functionality e enter a commit message to explain why this merge is necessary,
automated style fixes Co-authored-by: yuvrajdhadwal <yuvrajdhadwal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modifies Line Test so that now user can specify which points they want the robot to toggle between and which robot to test with.