Unique PID Parameters for each Robot#2513
Merged
Merged
Conversation
automated style fixes Co-authored-by: shourikb <shourikb@users.noreply.github.com>
CameronLyon
approved these changes
Mar 11, 2026
Contributor
CameronLyon
left a comment
There was a problem hiding this comment.
Worked out of sim so that's a success on many more levels 😅
Squid5678
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the sim and real params .yamls to use per robot PID values for rotation and translation, kp, kd, ki for robots 0-5. Modified the motion_control cpp and hpp files for this change, removed the constant DEFINES.
Associated / Resolved Issue
https://app.clickup.com/t/86b6w4xcu
Steps to Test
Expected result:
Should see the robot that had it's value change start moving weirdly, while the other robots remain fine.
Key Files to Review