Skip to content

Unique PID Parameters for each Robot#2513

Merged
shourikb merged 6 commits into
ros2from
unique-params
Mar 11, 2026
Merged

Unique PID Parameters for each Robot#2513
shourikb merged 6 commits into
ros2from
unique-params

Conversation

@shourikb
Copy link
Copy Markdown
Contributor

@shourikb shourikb commented Mar 9, 2026

Description

Changed the sim and real params .yamls to use per robot PID values for rotation and translation, kp, kd, ki for robots 0-5. Modified the motion_control cpp and hpp files for this change, removed the constant DEFINES.

Associated / Resolved Issue

https://app.clickup.com/t/86b6w4xcu

Steps to Test

  1. Source, make, and make run-sim
  2. In another terminal window, open up RQT using the rqt command after sourcing
  3. Run the simulator and note which robots are moving
  4. Change the kp value for one of the moving robots to 100000

Expected result:
Should see the robot that had it's value change start moving weirdly, while the other robots remain fine.

Key Files to Review

  • sim_params.yaml
  • real_params.yaml
  • motion_control.cpp
  • motion_control.hpp

automated style fixes

Co-authored-by: shourikb <shourikb@users.noreply.github.com>
@shourikb shourikb requested a review from CameronLyon March 11, 2026 00:45
Copy link
Copy Markdown
Contributor

@CameronLyon CameronLyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked out of sim so that's a success on many more levels 😅

Copy link
Copy Markdown
Contributor

@Squid5678 Squid5678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@shourikb shourikb merged commit b6f8302 into ros2 Mar 11, 2026
2 checks passed
@shourikb shourikb deleted the unique-params branch March 11, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants