Passing improvements#2516
Merged
Merged
Conversation
the passing works, but there are some issues still left in terms of wait time, kick distance, and occasional bugs that need to be worked on.
…be) on grey field bug.
…ot capable on shooting.
…ver goalie boxes.
…add a skip feature if the kick doesn't trigger.
…ulting to shooting if no one's open.
shourikb
approved these changes
Mar 9, 2026
Contributor
shourikb
left a comment
There was a problem hiding this comment.
Some minor things, other than that logically looks good
automated style fixes Co-authored-by: CameronLyon <CameronLyon@users.noreply.github.com>
Squid5678
approved these changes
Mar 16, 2026
Contributor
Squid5678
left a comment
There was a problem hiding this comment.
checked IRL seems good
shourikb
approved these changes
Mar 17, 2026
automated style fixes Co-authored-by: CameronLyon <CameronLyon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request tackles the issues with passing by basically revamping the entire code/behavior behind the communication between bots, shooting calculations, and ball interpretation fixes. Here's the current issue:
Issues:
This pull request responds to these issues with the following changes:
If there are any logical mistakes, vague areas that need commenting, or anything else, lmk on this PR. Thx 😀