Skip to content

fix: add missing standard library includes for header self-containment#90

Open
ZiningLi wants to merge 2 commits into
RoboSense-LiDAR:mainfrom
ZiningLi:main
Open

fix: add missing standard library includes for header self-containment#90
ZiningLi wants to merge 2 commits into
RoboSense-LiDAR:mainfrom
ZiningLi:main

Conversation

@ZiningLi

@ZiningLi ZiningLi commented May 21, 2026

Copy link
Copy Markdown

Summary

Adds missing standard library includes (<cstdint> and <memory>) to driver_param.hpp and input.hpp to ensure header self-containment and prevent compilation errors in strict build environments.

Problem

Two critical headers use standard library types without explicitly including the required headers, violating C++ best practices and causing compilation failures in some environments.

Compilation Errors (Without This Fix)

error: 'uint8_t' does not name a type
error: 'uint16_t' does not name a type
error: 'uint32_t' does not name a type
error: 'shared_ptr' is not a member of 'std'
note: 'std::shared_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?

@ZiningLi ZiningLi changed the title fix: add missing <cstdint> include in driver_param.hpp and input.hpp fix: add missing standard library includes for header self-containment May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant