fix: add missing standard library includes for header self-containment#90
Open
ZiningLi wants to merge 2 commits into
Open
fix: add missing standard library includes for header self-containment#90ZiningLi wants to merge 2 commits into
ZiningLi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing standard library includes (
<cstdint>and<memory>) todriver_param.hppandinput.hppto ensure header self-containment and prevent compilation errors in strict build environments.Problem
Two critical headers use standard library types without explicitly including the required headers, violating C++ best practices and causing compilation failures in some environments.
Compilation Errors (Without This Fix)