Send game version with slave despawn payload#1960
Merged
Robosturm merged 1 commit intoMay 5, 2026
Merged
Conversation
GameMenue::doDespawnSlave and Multiplayermenu::doSaveLobbyState constructed the SLAVEINFODESPAWNING JSON manually and never inserted versionMajor / versionMinor / versionRevision / versionSufix. MainServer::onSlaveInfoDespawning called NetworkGameData::fromJson on the message, which read those missing keys as 0 and the empty string, so each suspended-slave entry in m_runningSlaves and m_runningLobbies got stamped 0.0.0- as its game version. When a player tried to rejoin from the My Games view, LobbyMenu::checkGameVersion compared 0.0.0- against GameVersion() (the live binary) and refused the join with "Game has a different version. Game version: 0.0.0-". Insert the four version keys at both call sites, mirroring NetworkGameData:: toJson, so suspended games carry their actual version through the despawn / relaunch round trip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GameMenue::doDespawnSlave and Multiplayermenu::doSaveLobbyState constructed the SLAVEINFODESPAWNING JSON manually and never inserted versionMajor / versionMinor / versionRevision / versionSufix. MainServer::onSlaveInfoDespawning called NetworkGameData::fromJson on the message, which read those missing keys as 0 and the empty string, so each suspended-slave entry in m_runningSlaves and m_runningLobbies got stamped 0.0.0- as its game version. When a player tried to rejoin from the My Games view, LobbyMenu::checkGameVersion compared 0.0.0- against GameVersion() (the live binary) and refused the join with "Game has a different version. Game version: 0.0.0-".
Insert the four version keys at both call sites, mirroring NetworkGameData:: toJson, so suspended games carry their actual version through the despawn / relaunch round trip.