Commit 01731e0
authored
fix(types): add type declarations for the rclnodejs/rosocket subpath (#1533)
The `./rosocket` subpath export shipped **no type declarations**, so under `node16`/`nodenext` module resolution:
- `import { startRosocket } from 'rclnodejs/rosocket'` failed with **TS7016** (the module implicitly had an `any` type).
- `@arethetypeswrong` reported **No types** for the subpath across every resolution mode.
### Changes
- **Add `rosocket/index.d.ts`** — types the public entry point (`startRosocket`, `StartRosocketOptions`, `RosocketServer`), matched against `rosocket/index.js` (`port=9000`, `host='0.0.0.0'`, required `node`, returns `{ wss, close, port }`). `wss` is typed as its `EventEmitter` supertype to avoid a hard dependency on `ws` types.
- **Add `rosocket/index.d.cts`** — a CommonJS-format companion (re-exporting the `.d.ts`) so the `require` condition resolves to a CJS type file and is not flagged as "Masquerading as ESM".
- **Wire per-condition `types` into the `./rosocket` export** in `package.json` (`import` → `index.d.ts`, `require` → `index.d.cts`).
Fix: #15321 parent 774b637 commit 01731e0
3 files changed
Lines changed: 101 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
31 | 37 | | |
32 | 38 | | |
33 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
0 commit comments