Address comments

Author: minggangw

lib/interface_loader.js

@@ -57,7 +57,7 @@ let interfaceLoader = {
     }
 
     // TODO(Kenny): more checks of the string argument
-    if (name.indexOf('/') !== -1) {
+    if (name.includes('/')) {
       let [packageName, type, messageName] = name.split('/');
       return this.loadInterface(packageName, type, messageName);
     }

rosidl_gen/packages.js

@@ -61,7 +61,7 @@ function getSubFolder(filePath, amentExecuted) {
   }
   // If the |amentExecuted| equals to false, the file's extension will be assigned as
   // the name of sub folder.
-  return path.parse(filePath).ext.substr(1);
+  return path.parse(filePath).ext.substring(1);
 }
 
 function grabInterfaceInfo(filePath, amentExecuted) {

rosidl_gen/templates/message-template.js

@@ -164,7 +164,7 @@ function isTypedArrayType(type) {
 }
 
 function isBigInt(type) {
-  return ['int64', 'uint64'].indexOf(type.type.toLowerCase()) !== -1;
+  return ['int64', 'uint64'].includes(type.type.toLowerCase());
 }
 
 function getWrapperNameByType(type) {
@@ -283,7 +283,7 @@ function generateMessage(data) {
         !fieldType.isPrimitiveType ||
         fieldType.type === 'string');
 
-    if (shouldReq && existedModules.indexOf(requiredModule) === -1) {
+    if (shouldReq && !existedModules.includes(requiredModule)) {
       existedModules.push(requiredModule);
       return true;
     } else {
@@ -692,7 +692,7 @@ ${spec.fields
 
   hasMember(name) {
     let memberNames = ${extractMemberNames(spec.fields)};
-    return memberNames.indexOf(name) !== -1;
+    return memberNames.includes(name);
   }
 }`;
   }