Address comments

Author: minggangw

.github/workflows/linux-arm64-build-and-test.yml

@@ -95,9 +95,18 @@ jobs:
         # Fix ownership of the workspace to allow write access
         sudo chown -R $(whoami):$(whoami) $GITHUB_WORKSPACE
 
+    # Wrap the test step in nick-fields/retry@v4 to absorb transient flakes
+    # (mocha races, native rebuilds, Electron postinstall, network blips).
+    # Keep max_attempts low so real regressions still surface quickly.
     - name: Build and test rclnodejs
-      run: |
-        uname -a
-        source /opt/ros/${{ matrix.ros_distribution }}/setup.bash
-        npm i
-        npm test
+      uses: nick-fields/retry@v4
+      with:
+        shell: bash
+        max_attempts: 2
+        retry_wait_seconds: 10
+        timeout_minutes: 60
+        command: |
+          uname -a
+          source /opt/ros/${{ matrix.ros_distribution }}/setup.bash
+          npm i
+          npm test

.github/workflows/linux-x64-asan-test.yml

@@ -41,7 +41,16 @@ jobs:
         source /opt/ros/jazzy/setup.bash
         npm i
 
+    # Wrap the asan test step in nick-fields/retry@v4 to absorb transient
+    # flakes. ASan can be sensitive to timing-related test races; keep
+    # max_attempts low so real regressions still surface quickly.
     - name: Build and test with AddressSanitizer
-      run: |
-        source /opt/ros/jazzy/setup.bash
-        npm run test:asan
+      uses: nick-fields/retry@v4
+      with:
+        shell: bash
+        max_attempts: 2
+        retry_wait_seconds: 10
+        timeout_minutes: 60
+        command: |
+          source /opt/ros/jazzy/setup.bash
+          npm run test:asan

.github/workflows/linux-x64-build-and-test.yml

@@ -123,22 +123,39 @@ jobs:
 
     - uses: actions/checkout@v6
 
+    # The mocha suite and the Electron postinstall (extract-zip 2.0.1) are
+    # known to be intermittently flaky on this runner. Wrap both test
+    # invocations in nick-fields/retry@v4 so a single transient failure does
+    # not fail the whole matrix leg. Keep max_attempts conservative so real
+    # regressions still surface quickly.
     - name: Build and test rclnodejs
-      run: |
-        uname -a
-        source /opt/ros/${{ matrix.ros_distribution }}/setup.bash
-        npm i
-        npm run lint
-        npm test
-        npm run clean
+      uses: nick-fields/retry@v4
+      with:
+        shell: bash
+        max_attempts: 2
+        retry_wait_seconds: 10
+        timeout_minutes: 60
+        command: |
+          uname -a
+          source /opt/ros/${{ matrix.ros_distribution }}/setup.bash
+          npm i
+          npm run lint
+          npm test
+          npm run clean
 
     - name: Test with IDL ROS messages (rolling / lyrical)
       if: ${{ matrix.ros_distribution == 'rolling' || matrix.ros_distribution == 'lyrical' }}
-      run: |
-        source /opt/ros/${{ matrix.ros_distribution }}/setup.bash
-        npm i
-        npm run test-idl
-        npm run clean
+      uses: nick-fields/retry@v4
+      with:
+        shell: bash
+        max_attempts: 2
+        retry_wait_seconds: 10
+        timeout_minutes: 60
+        command: |
+          source /opt/ros/${{ matrix.ros_distribution }}/setup.bash
+          npm i
+          npm run test-idl
+          npm run clean
 
     - name: Coveralls
       if: ${{ matrix.ros_distribution == 'rolling' && matrix['node-version'] == '24.X' }}

.github/workflows/windows-build-and-test.yml

@@ -88,11 +88,19 @@ jobs:
         call "C:\pixi_ws\ros2-windows\setup.bat"
         npm i
 
+    # Wrap the test step in nick-fields/retry@v4 to absorb transient flakes
+    # (mocha races, native rebuilds, network blips). Keep max_attempts low so
+    # real regressions still surface quickly.
     - name: Test rclnodejs
       if: ${{ matrix.run_tests }}
-      shell: cmd
-      run: |
-        set PATH=C:\pixi_ws\.pixi\envs\default\Library\bin;C:\pixi_ws\.pixi\envs\default\Scripts;C:\pixi_ws\.pixi\envs\default\bin;%PATH%
-        set RMW_IMPLEMENTATION=rmw_fastrtps_cpp
-        call "C:\pixi_ws\ros2-windows\setup.bat"
-        npm test
+      uses: nick-fields/retry@v4
+      with:
+        shell: cmd
+        max_attempts: 2
+        retry_wait_seconds: 10
+        timeout_minutes: 60
+        command: |
+          set PATH=C:\pixi_ws\.pixi\envs\default\Library\bin;C:\pixi_ws\.pixi\envs\default\Scripts;C:\pixi_ws\.pixi\envs\default\bin;%PATH%
+          set RMW_IMPLEMENTATION=rmw_fastrtps_cpp
+          call "C:\pixi_ws\ros2-windows\setup.bat"
+          npm test