Address comments

minggangw · minggangw · commit 64853fe0c022 · 2025-11-14T13:18:57.000+08:00
diff --git a/test/test-rosidl-message-generator.js b/test/test-rosidl-message-generator.js
@@ -83,10 +83,12 @@ function buildTestMessage() {
   }
 
   // Build colcon command arguments
-  const colconArgs = ['build'];
+  // Note: --log-base must come before the 'build' subcommand
+  const colconArgs = [];
   if (logBase) {
     colconArgs.push('--log-base', logBase);
   }
+  colconArgs.push('build');
 
   const buildResult = require('child_process').spawnSync('colcon', colconArgs, {
     cwd: customMsgTestPath,

Original file line number	Diff line number	Diff line change
`@@ -83,10 +83,12 @@ function buildTestMessage() {`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`// Build colcon command arguments`
`86`		`- const colconArgs = ['build'];`
	`86`	`+ // Note: --log-base must come before the 'build' subcommand`
	`87`	`+ const colconArgs = [];`
`87`	`88`	`if (logBase) {`
`88`	`89`	`colconArgs.push('--log-base', logBase);`
`89`	`90`	`}`
	`91`	`+ colconArgs.push('build');`
`90`	`92`
`91`	`93`	`const buildResult = require('child_process').spawnSync('colcon', colconArgs, {`
`92`	`94`	`cwd: customMsgTestPath,`