Address comments

minggangw · minggangw · commit 865ebf7cfe98 · 2025-12-01T14:14:36.000+08:00
diff --git a/src/rcl_action_server_bindings.cpp b/src/rcl_action_server_bindings.cpp
@@ -333,9 +333,9 @@ Napi::Value ActionPublishStatus(const Napi::CallbackInfo& info) {
   }
 
   if (ret_fini != RCL_RET_OK) {
-    rcl_reset_error();
     Napi::Error::New(env, rcl_get_error_string().str)
         .ThrowAsJavaScriptException();
+    rcl_reset_error();
     return env.Undefined();
   }
 

Original file line number	Diff line number	Diff line change
`@@ -333,9 +333,9 @@ Napi::Value ActionPublishStatus(const Napi::CallbackInfo& info) {`
`333`	`333`	`}`
`334`	`334`
`335`	`335`	`if (ret_fini != RCL_RET_OK) {`
`336`		`- rcl_reset_error();`
`337`	`336`	`Napi::Error::New(env, rcl_get_error_string().str)`
`338`	`337`	`.ThrowAsJavaScriptException();`
	`338`	`+ rcl_reset_error();`
`339`	`339`	`return env.Undefined();`
`340`	`340`	`}`
`341`	`341`