Skip to content

Commit 8a1ce19

Browse files
authored
Refresh Electron prebuild target and demo apps (#1492)
The `prebuild:electron` script was still pinned to `electron@23.0.0`, an EOL release from Dec 2022 that bundles Node 18.12. Bump it to `electron@34.0.0`, the most recent line whose bundled Node (20.18.1) matches the major version of our `engines.node >= 20.20.2` floor. The four `electron_demo/*` apps were pinned to `^40.1.0`, which goes EOL on Jun 30, 2026. Bump them to `^41.0.0` (supported through Aug 25, 2026) so demos stay on a maintained, security-patched Electron line ahead of the Lyrical GA window. N-API ABI stability means binaries built against Electron 34 continue to load cleanly in 41+, so the prebuild-target / demo-target split is intentional and safe. Fix: #1458
1 parent ce7e8b4 commit 8a1ce19

5 files changed

Lines changed: 5 additions & 5 deletions

File tree

electron_demo/car/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"@electron-forge/plugin-auto-unpack-natives": "^7.11.1",
3131
"@electron-forge/plugin-fuses": "^7.11.1",
3232
"@electron/rebuild": "^4.0.3",
33-
"electron": "^40.1.0"
33+
"electron": "^41.0.0"
3434
},
3535
"config": {
3636
"forge": {

electron_demo/manipulator/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"@electron-forge/plugin-auto-unpack-natives": "^7.11.1",
3535
"@electron-forge/plugin-fuses": "^7.11.1",
3636
"@electron/rebuild": "^4.0.3",
37-
"electron": "^40.1.0"
37+
"electron": "^41.0.0"
3838
},
3939
"config": {
4040
"forge": {

electron_demo/topics/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"@electron-forge/plugin-auto-unpack-natives": "^7.11.1",
2828
"@electron-forge/plugin-fuses": "^7.11.1",
2929
"@electron/rebuild": "^4.0.3",
30-
"electron": "^40.1.0"
30+
"electron": "^41.0.0"
3131
},
3232
"config": {
3333
"forge": {

electron_demo/turtle_tf2/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"@electron-forge/plugin-auto-unpack-natives": "^7.11.1",
3434
"@electron-forge/plugin-fuses": "^7.11.1",
3535
"@electron/rebuild": "^4.0.3",
36-
"electron": "^40.1.0"
36+
"electron": "^41.0.0"
3737
},
3838
"config": {
3939
"forge": {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"prepare": "husky",
3636
"coverage": "cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js",
3737
"prebuild:node": "prebuildify --napi --strip --name node --target 20.20.2",
38-
"prebuild:electron": "prebuildify --napi --strip --name electron --target electron@23.0.0",
38+
"prebuild:electron": "prebuildify --napi --strip --name electron --target electron@34.0.0",
3939
"prebuild": "npm run prebuild:node && npm run prebuild:electron && node scripts/tag_prebuilds.js"
4040
},
4141
"bin": {

0 commit comments

Comments
 (0)