Address comments

Author: minggangw

electron_demo/car/renderer.js

@@ -11,6 +11,7 @@
 // limitations under the License.
 
 const { ipcRenderer } = require('electron');
+const process = require('process');
 
 // DOM elements
 let currentCommandEl, linearXEl, angularZEl, topicNameEl;

electron_demo/topics/renderer.js

@@ -11,13 +11,16 @@
 // limitations under the License.
 
 const { ipcRenderer } = require('electron');
+const process = require('process');
 
-const versionDiv = document.createElement('div');
-versionDiv.style.position = 'fixed';
-versionDiv.style.bottom = '10px';
-versionDiv.style.left = '10px';
-versionDiv.innerText = 'Electron version: ' + process.versions.electron;
-document.body.appendChild(versionDiv);
+document.addEventListener('DOMContentLoaded', () => {
+  const versionDiv = document.createElement('div');
+  versionDiv.style.position = 'fixed';
+  versionDiv.style.bottom = '10px';
+  versionDiv.style.left = '10px';
+  versionDiv.innerText = 'Electron version: ' + process.versions.electron;
+  document.body.appendChild(versionDiv);
+});
 
 ipcRenderer.on('topic-received', function (event, response) {
   document.getElementById('received-topic').innerText = response;

electron_demo/turtle_tf2/main.js

@@ -335,7 +335,7 @@ async function createTurtleTf2Listener() {
   );
 
   // Timer to check for transforms and control turtle2
-  const timer = node.createTimer(1000n, () => {
+  node.createTimer(1000n, () => {
     // Wrap the async logic in a try-catch to handle promise rejections
     (async () => {
       try {
@@ -442,7 +442,7 @@ async function createDynamicFrameTf2Broadcaster() {
   const tfBroadcaster = node.createPublisher('tf2_msgs/msg/TFMessage', '/tf');
 
   // Timer to broadcast dynamic transform
-  const timer = node.createTimer(100n, () => {
+  node.createTimer(100n, () => {
     const now = node.now();
 
     // Use a more stable time calculation to avoid NaN
@@ -535,7 +535,7 @@ async function createFixedFrameTf2Broadcaster() {
   const tfBroadcaster = node.createPublisher('tf2_msgs/msg/TFMessage', '/tf');
 
   // Timer to broadcast fixed transform
-  const timer = node.createTimer(100n, () => {
+  node.createTimer(100n, () => {
     const now = node.now();
     const fixedTransform = {
       header: {

test/electron/run_test.js

@@ -0,0 +1,36 @@
+'use strict';
+
+const path = require('path');
+const { spawn } = require('child_process');
+
+let electron;
+try {
+  electron = require('electron');
+} catch (e) {
+  console.error(
+    'Electron module not found. Please install electron to run this test.'
+  );
+  process.exit(1);
+}
+
+console.log('Launching Electron to run test_usability.js...');
+const child = spawn(electron, [path.join(__dirname, 'test_usability.js')], {
+  stdio: 'inherit',
+  env: { ...process.env, ELECTRON_ENABLE_LOGGING: true },
+});
+
+child.on('close', (code) => {
+  console.log(`Electron process exited with code ${code}`);
+  if (code === 0) {
+    console.log('Test Passed!');
+    process.exit(0);
+  } else {
+    console.error('Test Failed!');
+    process.exit(1);
+  }
+});
+
+child.on('error', (err) => {
+  console.error('Failed to start electron:', err);
+  process.exit(1);
+});

test/electron/test_usability.js

@@ -0,0 +1,57 @@
+'use strict';
+
+const rclnodejs = require('../../index.js');
+const { app } = require('electron');
+
+app.on('ready', () => {
+  console.log('Electron version:', process.versions.electron);
+  rclnodejs
+    .init()
+    .then(() => {
+      console.log('rclnodejs initialized successfully.');
+      const node = rclnodejs.createNode('test_electron_node');
+      const publisher = node.createPublisher(
+        'std_msgs/msg/String',
+        'electron_test_topic'
+      );
+
+      const subscription = node.createSubscription(
+        'std_msgs/msg/String',
+        'electron_test_topic',
+        (msg) => {
+          if (msg.data === 'Hello from Electron') {
+            console.log(
+              'Successfully received message in Electron environment.'
+            );
+            rclnodejs.shutdown();
+            app.quit();
+            process.exit(0);
+          }
+        }
+      );
+
+      console.log('Publisher and Subscriber created.');
+
+      // Publish repeatedly until received
+      const interval = setInterval(() => {
+        publisher.publish('Hello from Electron');
+        console.log('Published message...');
+      }, 100);
+
+      // Set a timeout to fail the test
+      setTimeout(() => {
+        console.error('Test Failed: Timeout waiting for message.');
+        clearInterval(interval);
+        rclnodejs.shutdown();
+        app.quit();
+        process.exit(1);
+      }, 10000);
+
+      rclnodejs.spin(node);
+    })
+    .catch((e) => {
+      console.error('Initialization failed:', e);
+      app.quit();
+      process.exit(1);
+    });
+});