Address comments

Author: minggangw

.github/workflows/linux-arm64-build-and-test.yml

@@ -61,3 +61,4 @@ jobs:
         source /opt/ros/${{ matrix.ros_distribution }}/setup.bash
         npm i
         npm test
+        npm run clean

lib/client.js

@@ -17,11 +17,6 @@
 const rclnodejs = require('./native_loader.js');
 const DistroUtils = require('./distro.js');
 const Entity = require('./entity.js');
-const {
-  TypeValidationError,
-  TimeoutError,
-  AbortError,
-} = require('./errors.js');
 const debug = require('debug')('rclnodejs:client');
 
 // Polyfill for AbortSignal.any() for Node.js <= 20.3.0
@@ -101,10 +96,7 @@ class Client extends Entity {
    */
   sendRequest(request, callback) {
     if (typeof callback !== 'function') {
-      throw new TypeValidationError('callback', callback, 'function', {
-        entityType: 'service',
-        entityName: this._serviceName,
-      });
+      throw new TypeError('Invalid argument');
     }
 
     let requestToSend =
@@ -125,8 +117,8 @@ class Client extends Entity {
    * @param {number} [options.timeout] - Timeout in milliseconds for the request.
    * @param {AbortSignal} [options.signal] - AbortSignal to cancel the request.
    * @return {Promise<object>} Promise that resolves with the service response.
-   * @throws {module:rclnodejs.TimeoutError} If the request times out (when options.timeout is exceeded).
-   * @throws {module:rclnodejs.AbortError} If the request is manually aborted (via options.signal).
+   * @throws {TimeoutError} If the request times out (when options.timeout is exceeded).
+   * @throws {AbortError} If the request is manually aborted (via options.signal).
    * @throws {Error} If the request fails for other reasons.
    */
   sendRequestAsync(request, options = {}) {
@@ -160,31 +152,31 @@ class Client extends Entity {
 
       if (effectiveSignal) {
         if (effectiveSignal.aborted) {
-          const error = isTimeout
-            ? new TimeoutError('Service request', options.timeout, {
-                entityType: 'service',
-                entityName: this._serviceName,
-              })
-            : new AbortError('Service request', undefined, {
-                entityType: 'service',
-                entityName: this._serviceName,
-              });
+          const error = new Error(
+            isTimeout
+              ? `Request timeout after ${options.timeout}ms`
+              : 'Request was aborted'
+          );
+          error.name = isTimeout ? 'TimeoutError' : 'AbortError';
+          if (isTimeout) {
+            error.code = 'TIMEOUT';
+          }
           reject(error);
           return;
         }
 
         effectiveSignal.addEventListener('abort', () => {
           if (!isResolved) {
             cleanup();
-            const error = isTimeout
-              ? new TimeoutError('Service request', options.timeout, {
-                  entityType: 'service',
-                  entityName: this._serviceName,
-                })
-              : new AbortError('Service request', undefined, {
-                  entityType: 'service',
-                  entityName: this._serviceName,
-                });
+            const error = new Error(
+              isTimeout
+                ? `Request timeout after ${options.timeout}ms`
+                : 'Request was aborted'
+            );
+            error.name = isTimeout ? 'TimeoutError' : 'AbortError';
+            if (isTimeout) {
+              error.code = 'TIMEOUT';
+            }
             reject(error);
           }
         });

test/test-rosidl-message-generator.js

@@ -64,16 +64,6 @@ function buildTestMessage() {
   // Build the custom_msg_test package synchronously before running the test
   const customMsgTestPath = path.join(__dirname, 'custom_msg_test');
 
-  // List packages to ensure colcon can discover them
-  require('child_process').spawnSync(
-    'colcon',
-    ['--log-base', '/dev/null', 'list'],
-    {
-      cwd: customMsgTestPath,
-      stdio: 'inherit',
-    }
-  );
-
   const buildResult = require('child_process').spawnSync('colcon', ['build'], {
     cwd: customMsgTestPath,
     stdio: 'inherit',