Address comments

Author: minggangw

binding.gyp

@@ -104,6 +104,22 @@
             'defines': [
               'OS_WINDOWS'
             ],
+            'conditions': [
+              [
+                'node_major_version >= 23', {
+                  'cflags_cc': [
+                    '-std=c++20'
+                  ]
+                }
+              ],
+              [
+                'node_major_version < 23', {
+                  'cflags_cc': [
+                    '-std=c++17'
+                  ]
+                }
+              ]
+            ],
             'include_dirs': [
               './src/third_party/dlfcn-win32/',
             ],
@@ -113,7 +129,6 @@
             'msvs_settings': {
               'VCCLCompilerTool': {
                 'ExceptionHandling': '2', # /EHsc
-                'AdditionalOptions': ['/std:c++20']
               },
               'VCLinkerTool': {
                 'AdditionalDependencies': ['psapi.lib'],
@@ -132,7 +147,7 @@
               'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
               'CLANG_CXX_LIBRARY': 'libc++',
               'MACOS_DEPLOYMENT_TARGET': '10.12',
-              'CLANG_CXX_LANGUAGE_STANDARD': 'c++20'
+              'CLANG_CXX_LANGUAGE_STANDARD': 'c++17'
             }
           }
         ],

rosidl_gen/primitive_types.js

@@ -16,7 +16,6 @@
 
 const ref = require('../third_party/ref-napi');
 const StructType = require('@rclnodejs/ref-struct-di')(ref);
-// const rclnodejs = require('bindings')('rclnodejs');
 const rclnodejs = require('../lib/native_loader.js');
 
 const StringRefStruct = StructType({

third_party/ref-napi/lib/ref.js

@@ -3,11 +3,6 @@ const assert = require('assert');
 const inspect = require('util').inspect;
 const debug = require('debug')('ref');
 const os = require('os');
-const path = require('path');
-// const addon = require('bindings')({
-//   bindings: 'rclnodejs',
-//   module_root: path.resolve(__dirname, '..', '..', '..'),
-// });
 const addon = require('../../../lib/native_loader.js');
 
 if (!addon || !addon.ref) {