Address comments

Author: minggangw

lib/action/uuid.js

@@ -40,7 +40,7 @@ class ActionUuid {
       this._bytes = bytes;
     } else {
       // Generate random UUID.
-      let uuid = randomUUID().replace(/-/g, '');
+      let uuid = randomUUID().replaceAll('-', '');
       this._bytes = Uint8Array.from(Buffer.from(uuid, 'hex'));
     }
   }

rosidl_gen/packages.js

@@ -29,7 +29,7 @@ const serviceMsgPath = path.join(generatedRoot, 'srv_msg');
 
 function getPackageName(filePath, amentExecuted) {
   if (os.type() === 'Windows_NT') {
-    filePath = filePath.replace(/\\/g, '/');
+    filePath = filePath.replaceAll('\\', '/');
   }
 
   if (amentExecuted) {
@@ -41,14 +41,14 @@ function getPackageName(filePath, amentExecuted) {
 
   // If |packageName| equals to the file's extension, e.g. msg/srv, one level
   // up directory will be used as the package name.
-  return packageName === path.parse(filePath).ext.substr(1)
+  return packageName === path.parse(filePath).ext.substring(1)
     ? folders.pop()
     : packageName;
 }
 
 function getSubFolder(filePath, amentExecuted) {
   if (os.type() === 'Windows_NT') {
-    filePath = filePath.replace(/\\/g, '/');
+    filePath = filePath.replaceAll('\\', '/');
   }
 
   if (amentExecuted) {

rosidl_gen/templates/message-template.js

@@ -156,11 +156,11 @@ const typedArrayType = [
 ];
 
 function isPrimitivePackage(baseType) {
-  return primitiveBaseType.indexOf(baseType.type) !== -1;
+  return primitiveBaseType.includes(baseType.type);
 }
 
 function isTypedArrayType(type) {
-  return typedArrayType.indexOf(type.type.toLowerCase()) !== -1;
+  return typedArrayType.includes(type.type.toLowerCase());
 }
 
 function isBigInt(type) {

scripts/run_test.js

@@ -27,7 +27,7 @@ utils
     const testDir = path.join(__dirname, '../test/');
     // eslint-disable-next-line
     const tests = fs.readdirSync(testDir).filter((file) => {
-      return file.substr(0, 5) === 'test-';
+      return file.startsWith('test-');
     });
 
     // eslint-disable-next-line
@@ -37,7 +37,7 @@ utils
     let ignoredCases = blocklist[os.type()];
 
     tests.forEach((test) => {
-      if (ignoredCases.indexOf(test) === -1) {
+      if (!ignoredCases.includes(test)) {
         mocha.addFile(path.join(testDir, test));
       }
     });