Remove outdated Dockerfile#1262
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes an outdated Dockerfile and replaces it with documentation pointing users to official ROS Docker images. The change simplifies the project by eliminating maintenance of a custom Docker setup while providing clear guidance for containerized builds.
Key changes:
- Complete removal of the custom Dockerfile
- Addition of Docker guidance in README and npmjs documentation pointing to official ROS images
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Dockerfile | Removes the entire custom Docker configuration |
| README.md | Adds Docker guidance directing users to official ROS images |
| scripts/npmjs-readme.md | Adds the same Docker guidance for npm package documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - [Node.js](https://nodejs.org/en/) version >= 16.13.0 | ||
| - [ROS 2 SDK](https://docs.ros.org/en/jazzy/Installation.html) - **Don't forget to [source the setup file](https://docs.ros.org/en/jazzy/Tutorials/Beginner-CLI-Tools/Configuring-ROS2-Environment.html#source-the-setup-files)** | ||
|
|
||
| > **Docker:** Use official ROS images from [hub.docker.com/\_/ros](https://hub.docker.com/_/ros) for containerized builds. |
There was a problem hiding this comment.
The URL contains an unnecessary backslash escape before the underscore. The underscore doesn't need to be escaped in markdown links.
Suggested change
| > **Docker:** Use official ROS images from [hub.docker.com/\_/ros](https://hub.docker.com/_/ros) for containerized builds. | |
| > **Docker:** Use official ROS images from [hub.docker.com/_/ros](https://hub.docker.com/_/ros) for containerized builds. |
| - [Node.js](https://nodejs.org/en/) version >= 16.13.0 | ||
| - [ROS 2 SDK](https://docs.ros.org/en/jazzy/Installation.html) - **Don't forget to [source the setup file](https://docs.ros.org/en/jazzy/Tutorials/Beginner-CLI-Tools/Configuring-ROS2-Environment.html#source-the-setup-files)** | ||
|
|
||
| > **Docker:** Use official ROS images from [hub.docker.com/\_/ros](https://hub.docker.com/_/ros) for containerized builds. |
There was a problem hiding this comment.
The URL contains an unnecessary backslash escape before the underscore. The underscore doesn't need to be escaped in markdown links.
Suggested change
| > **Docker:** Use official ROS images from [hub.docker.com/\_/ros](https://hub.docker.com/_/ros) for containerized builds. | |
| > **Docker:** Use official ROS images from [hub.docker.com/_/ros](https://hub.docker.com/_/ros) for containerized builds. |
minggangw
added a commit
that referenced
this pull request
Sep 16, 2025
This PR updates an outdated Dockerfile. Key changes: - Update current Dockerfile - Addition of Docker guidance in README pointing to Dockerfile Fix: #1261
minggangw
added a commit
that referenced
this pull request
Oct 13, 2025
This PR updates an outdated Dockerfile. Key changes: - Update current Dockerfile - Addition of Docker guidance in README pointing to Dockerfile Fix: #1261
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes an outdated Dockerfile and replaces it with documentation pointing users to official ROS Docker images. The change simplifies the project by eliminating maintenance of a custom Docker setup while providing clear guidance for containerized builds.
Key changes:
Fix: #1261