Skip to content

Add README for typescript demos for indexing#1276

Merged
minggangw merged 2 commits into
RobotWebTools:developfrom
minggangw:fix-1275
Sep 22, 2025
Merged

Add README for typescript demos for indexing#1276
minggangw merged 2 commits into
RobotWebTools:developfrom
minggangw:fix-1275

Conversation

@minggangw

@minggangw minggangw commented Sep 22, 2025

Copy link
Copy Markdown
Member

This PR adds a comprehensive README file for the TypeScript demos directory, providing documentation for ROS2 communication pattern demonstrations with TypeScript type safety.

  • Added detailed documentation explaining three demo categories: topics, services, and actions
  • Included structured overview of TypeScript features and development practices
  • Created complexity progression table to guide users through learning path

Fix: #1275

Copilot AI review requested due to automatic review settings September 22, 2025 08:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive README file for the TypeScript demos directory, providing documentation for ROS2 communication pattern demonstrations with TypeScript type safety.

  • Added detailed documentation explaining three demo categories: topics, services, and actions
  • Included structured overview of TypeScript features and development practices
  • Created complexity progression table to guide users through learning path

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread ts_demo/README.md Outdated
- **Action Client**: Sends goals, monitors progress, handles results
- **Features**: Goal cancellation, feedback processing, result handling

## 📊 Complexity Progression

Copilot AI Sep 22, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two '## 📊 Complexity Progression' headings (lines 31 and 54). The first one on line 31 appears to be incomplete with no content, while the second one has the actual table. Remove the duplicate heading on line 31.

Suggested change
## 📊 Complexity Progression

Copilot uses AI. Check for mistakes.
Comment thread ts_demo/README.md Outdated

## 📊 Complexity Progression

## ️ TypeScript Features

Copilot AI Sep 22, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The emoji spacing is inconsistent. There's an extra space in '## ️' - it should be '## 🔧 TypeScript Features' or similar to match the pattern used in other headings.

Copilot uses AI. Check for mistakes.
@coveralls

coveralls commented Sep 22, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 84.306% (-0.03%) from 84.337%
when pulling 13bb72f on minggangw:fix-1275
into 9cd592e on RobotWebTools:develop.

@minggangw minggangw merged commit 607e704 into RobotWebTools:develop Sep 22, 2025
18 checks passed
minggangw added a commit that referenced this pull request Oct 13, 2025
This PR adds a comprehensive README file for the TypeScript demos directory, providing documentation for ROS2 communication pattern demonstrations with TypeScript type safety.

- Added detailed documentation explaining three demo categories: topics, services, and actions
- Included structured overview of TypeScript features and development practices
- Created complexity progression table to guide users through learning path

Fix: #1275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add README for typescript demos for indexing

3 participants