Remove fs-extra dependency#1302
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the fs-extra dependency by implementing equivalent filesystem utilities using Node.js built-in modules. The change replaces fs-extra with custom utility functions that provide the same functionality while reducing external dependencies.
Key changes:
- Created a comprehensive utils module with filesystem operations equivalent to fs-extra
- Updated all imports to use the new utility module instead of fs-extra
- Removed fs-extra from package.json dependencies
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/utils.js | Added comprehensive filesystem utility functions to replace fs-extra functionality |
| scripts/run_test.js | Updated to use new utils module and promise-based API for directory removal |
| rosidl_gen/index.js | Replaced fs-extra import with utils module |
| rosidl_gen/idl_generator.js | Replaced fs-extra import with utils module |
| rosidl_gen/generate_worker.js | Replaced fs-extra import with utils module |
| rosidl_convertor/idl_convertor.js | Updated to use standard fs for existsSync and utils for other operations |
| package.json | Removed fs-extra dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
minggangw
added a commit
that referenced
this pull request
Oct 30, 2025
This PR removes the fs-extra dependency by implementing equivalent filesystem utilities using Node.js built-in modules. The change replaces fs-extra with custom utility functions that provide the same functionality while reducing external dependencies. Key changes: - Created a comprehensive utils module with filesystem operations equivalent to fs-extra - Updated all imports to use the new utility module instead of fs-extra - Removed fs-extra from package.json dependencies Fix: #1300
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the fs-extra dependency by implementing equivalent filesystem utilities using Node.js built-in modules. The change replaces fs-extra with custom utility functions that provide the same functionality while reducing external dependencies.
Key changes:
Fix: #1300