Skip to content

Remove rolling from Windows action#1352

Merged
minggangw merged 1 commit into
RobotWebTools:developfrom
minggangw:fix-rolling-failure
Dec 15, 2025
Merged

Remove rolling from Windows action#1352
minggangw merged 1 commit into
RobotWebTools:developfrom
minggangw:fix-rolling-failure

Conversation

@minggangw

@minggangw minggangw commented Dec 15, 2025

Copy link
Copy Markdown
Member

We are going to remove rolling build from Windows action becaue recently downloading package from https://ci.ros2.org/view/packaging/ needs authentication.

Fix: ##1353

Copilot AI review requested due to automatic review settings December 15, 2025 05:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Windows action failures by updating the Jenkins artifact URL used to download ROS2 packages. The change switches from using lastSuccessfulBuild to lastStableBuild to ensure more reliable builds.

  • Changed Jenkins build selector from lastSuccessfulBuild to lastStableBuild for the rolling distribution artifact download

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls

coveralls commented Dec 15, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 80.623% (+0.02%) from 80.602%
when pulling c9ed5d1 on minggangw:fix-rolling-failure
into 4b61a6e on RobotWebTools:develop.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@minggangw minggangw changed the title Fix windows action failure on Windows Remove rolling from Windows action Dec 15, 2025
@minggangw minggangw merged commit a8e289c into RobotWebTools:develop Dec 15, 2025
25 of 26 checks passed
minggangw added a commit that referenced this pull request Jan 6, 2026
We are going to remove `rolling` build from Windows action becaue recently downloading package from https://ci.ros2.org/view/packaging/ needs authentication.

Fix: ##1353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants