Skip to content
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions .github/workflows/linux-x64-build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,21 +76,8 @@ jobs:
npm run test-idl
npm run clean

- name: Coveralls Parallel
- name: Coveralls
if: ${{ matrix.ros_distribution == 'rolling' && matrix['node-version'] == '24.X' }}
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
flag-name: run-${{ inputs.trigger_type }}-${{ matrix.node-version }}-${{ matrix.architecture }}
parallel: true

finish:
needs: build
if: always()
runs-on: ubuntu-latest
steps:
- name: Coveralls Finished
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
parallel-finished: true
2 changes: 1 addition & 1 deletion lib/message_serialization.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function toPlainArrays(obj) {
* @returns {*} The JSON-safe converted object
*/
function toJSONSafe(obj) {
if (obj === null || obj === undefined) {
if (obj === null) {
Comment thread
minggangw marked this conversation as resolved.
Outdated
return obj;
}

Expand Down
12 changes: 11 additions & 1 deletion lib/native_loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,4 +175,14 @@ function loadNativeAddon() {
}
}

module.exports = loadNativeAddon();
const addon = loadNativeAddon();

// Export internal functions for testing purposes
if (process.env.NODE_ENV === 'test') {
addon.TestHelpers = {
customFallbackLoader,
loadNativeAddon,
};
}

module.exports = addon;
2 changes: 1 addition & 1 deletion lib/time_source.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class TimeSource {
* @return {undefined}
*/
attachNode(node) {
if ((!node) instanceof rclnodejs.ShadowNode) {
if (!(node instanceof rclnodejs.ShadowNode)) {
throw new TypeValidationError('node', node, 'Node', {
entityType: 'time source',
});
Expand Down
Loading
Loading