Fix flakiness of test-type-description-service.js#1367
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes flakiness in the test-type-description-service.js test file by preventing multiple calls to the done() callback in asynchronous tests. The root cause was that after calling done() with an error, the callback would continue executing and potentially call done() again, causing test failures.
Changes:
- Added
returnstatements afterdone()calls in error handling blocks to prevent continued execution - Enhanced error messages to include actual error and stderr details for better debugging
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
minggangw
added a commit
that referenced
this pull request
Jan 22, 2026
This PR fixes flakiness in the test-type-description-service.js test file by preventing multiple calls to the `done()` callback in asynchronous tests. The root cause was that after calling `done()` with an error, the callback would continue executing and potentially call `done()` again, causing test failures. **Changes:** - Added `return` statements after `done()` calls in error handling blocks to prevent continued execution - Enhanced error messages to include actual error and stderr details for better debugging Fix: #1366
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes flakiness in the test-type-description-service.js test file by preventing multiple calls to the
done()callback in asynchronous tests. The root cause was that after callingdone()with an error, the callback would continue executing and potentially calldone()again, causing test failures.Changes:
returnstatements afterdone()calls in error handling blocks to prevent continued executionFix: #1366