Correct the type of return value for Time.toMsg()#1371
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request corrects the return type of the Time.toMsg() method to return JavaScript numbers instead of bigints for the sec and nanosec fields, aligning with ROS2's builtin_interfaces.msg.Time message specification which uses int32 for sec and uint32 for nanosec.
Changes:
- Modified
Time.toMsg()to convert bigint values to numbers usingNumber() - Updated test expectations to verify numbers are returned instead of bigints
- Added test case verifying
Time.fromMsg()compatibility with number types
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/time.js | Wraps sec and nanosec with Number() to convert from bigint to number in toMsg() |
| test/test-time.js | Updates assertions to expect numbers and adds type verification; adds test for fromMsg() accepting number inputs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
minggangw
added a commit
that referenced
this pull request
Jan 22, 2026
This pull request corrects the return type of the `Time.toMsg()` method to return JavaScript numbers instead of bigints for the `sec` and `nanosec` fields, aligning with ROS2's builtin_interfaces.msg.Time message specification which uses int32 for sec and uint32 for nanosec. **Changes:** - Modified `Time.toMsg()` to convert bigint values to numbers using `Number()` - Updated test expectations to verify numbers are returned instead of bigints - Added test case verifying `Time.fromMsg()` compatibility with number types Fix: #1370
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request corrects the return type of the
Time.toMsg()method to return JavaScript numbers instead of bigints for thesecandnanosecfields, aligning with ROS2's builtin_interfaces.msg.Time message specification which uses int32 for sec and uint32 for nanosec.Changes:
Time.toMsg()to convert bigint values to numbers usingNumber()Time.fromMsg()compatibility with number typesFix: #1370