-
Notifications
You must be signed in to change notification settings - Fork 85
Add support check for content filter feature in subscription #1451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
a201c28
73a4aaa
cced547
fdf6746
a76200e
ef17a64
b228f52
58a8aca
a2bf1b5
762b259
f9a92d8
c439dde
0c534ae
1205ac2
a0cc7eb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -47,12 +47,11 @@ def get_json_object_from_msg_spec_object(msg_spec_object): | |||||
|
|
||||||
| if __name__ == '__main__': | ||||||
| if len(sys.argv) < 4: | ||||||
| print('Usage: {} <command> <packageName> <filePath>'.format(sys.argv[0]), file=sys.stderr) | ||||||
| print('Wrong number of argments') | ||||||
|
||||||
| print('Wrong number of argments') | |
| print('Wrong number of arguments') |
Copilot
AI
Mar 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change in rosidl_parser/parser.py (updating the CLI arg-count error message) doesn’t appear related to the PR’s stated goal of adding a subscription content-filter support check. If it’s not required for the feature, consider reverting it or splitting it into a separate PR to keep changes focused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The argument-count check regresses error reporting: it now prints a generic message to stdout and drops the detailed usage message (previously printed to stderr). This makes failures from rosidl_parser/rosidl_parser.js much harder to diagnose because the Node-side error includes
stderr was: ...and will now often be empty. Consider restoring the originalUsage: <command> <packageName> <filePath>message and printing it to stderr.