Enable noImplicitAny#1066
Merged
Merged
Conversation
EzraBrooks
commented
Nov 13, 2025
Comment on lines
+36
to
+38
| interface TypeDefDict { | ||
| [key: string]: string | string[] | TypeDefDict | TypeDefDict[]; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
literally wtf is this type lmao
EzraBrooks
force-pushed
the
enable-noImplicitAny
branch
from
d0e4fd9 to
d50b913
Compare
bjsowa
approved these changes
Nov 13, 2025
|
|
||
| /* Rules to be enabled */ | ||
| "exactOptionalPropertyTypes": false /* Differentiate between undefined and not present when type checking */, | ||
| "noImplicitAny": false /* Enable error reporting for expressions and declarations with an implied 'any' type. */, |
Member
There was a problem hiding this comment.
Should probably move it to the enabled section but if your next PR is to just replace every rule with strict: true then it doesn't really matter.
Contributor
Author
There was a problem hiding this comment.
yep, one sec, I realized this and also that as of this PR we can set strict: true and remove a bunch of these explicit settings
EzraBrooks
force-pushed
the
enable-noImplicitAny
branch
from
ae5414b to
860e89b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wow, we'd done such a good job up to this point that this wasn't a miserable slog