[kicad:model] Added const ref to complex types getters

Author: sebcaux

src/kicad/model/drawtext.cpp

@@ -40,7 +40,7 @@ Draw::TypeDraw DrawText::type() const
     return TypeDrawText;
 }
 
-QString DrawText::text() const
+const QString &DrawText::text() const
 {
     return _text;
 }

src/kicad/model/drawtext.h

@@ -32,7 +32,7 @@ class KICAD_EXPORT DrawText : public Draw
 
     TypeDraw type() const override;
 
-    QString text() const;
+    const QString &text() const;
     void setText(const QString &text);
 
     enum Direction

src/kicad/model/lib.cpp

@@ -63,7 +63,7 @@ Lib::~Lib()
  * @brief Lib name getter
  * @return name
  */
-QString Lib::name() const
+const QString &Lib::name() const
 {
     return _name;
 }

src/kicad/model/lib.h

@@ -32,7 +32,7 @@ class KICAD_EXPORT Lib
     Lib(const Lib &other);
     ~Lib();
 
-    QString name() const;
+    const QString &name() const;
     void setName(const QString &name);
 
     Component *component(int i) const;

src/kicad/model/pad.cpp

@@ -35,7 +35,7 @@ void Pad::setName(const QString &name)
     _name = name;
 }
 
-QPointF Pad::pos() const
+const QPointF &Pad::pos() const
 {
     return _pos;
 }
@@ -45,7 +45,7 @@ void Pad::setPos(const QPointF &pos)
     _pos = pos;
 }
 
-QSizeF Pad::size() const
+const QSizeF &Pad::size() const
 {
     return _size;
 }
@@ -81,7 +81,7 @@ void Pad::setShape(const Shape &shape)
     _shape = shape;
 }
 
-QSizeF Pad::sizeIncrease() const
+const QSizeF &Pad::sizeIncrease() const
 {
     return _sizeIncrease;
 }
@@ -101,7 +101,7 @@ void Pad::setDrillDiameter(double drillDiameter)
     _drillDiameter = drillDiameter;
 }
 
-QPointF Pad::drillOffset() const
+const QPointF &Pad::drillOffset() const
 {
     return _drillOffset;
 }

src/kicad/model/pad.h

@@ -83,17 +83,17 @@ class KICAD_EXPORT Pad
     void setName(const QString &name);
 
     // pad
-    QPointF pos() const;
+    const QPointF &pos() const;
     void setPos(const QPointF &pos);
 
-    QSizeF size() const;
+    const QSizeF &size() const;
     void setSize(const QSizeF &size);
 
     Shape shape() const;
     QString shapeString() const;
     void setShape(const Shape &shape);
 
-    QSizeF sizeIncrease() const;
+    const QSizeF &sizeIncrease() const;
     void setSizeIncrease(const QSizeF &sizeIncrease);
 
     double angle() const;
@@ -103,7 +103,7 @@ class KICAD_EXPORT Pad
     double drillDiameter() const;
     void setDrillDiameter(double drillDiameter);
 
-    QPointF drillOffset() const;
+    const QPointF &drillOffset() const;
     void setDrillOffset(const QPointF &drillOffset);
 
     // attributes

src/kicad/model/pin.cpp

@@ -66,7 +66,7 @@ Pin::Pin(const Pin &other)
     _textPadSize = other._textPadSize;
 }
 
-QString Pin::name() const
+const QString &Pin::name() const
 {
     return _name;
 }
@@ -76,7 +76,7 @@ void Pin::setName(const QString &name)
     _name = name;
 }
 
-QPoint Pin::pos() const
+const QPoint &Pin::pos() const
 {
     return _pos;
 }
@@ -137,7 +137,7 @@ void Pin::setAngle(int angle)
     _angle = angle;
 }
 
-QString Pin::padName() const
+const QString &Pin::padName() const
 {
     return _padName;
 }
@@ -180,7 +180,7 @@ QString Pin::pinTypeDesc(PinType pinType)
     return QLatin1String("");
 }
 
-void Pin::setPinType(const Pin::PinType &pinType)
+void Pin::setPinType(PinType pinType)
 {
     _pinType = pinType;
 }
@@ -277,7 +277,7 @@ void Pin::setLength(int length)
     }
 }
 
-QString Pin::className() const
+const QString &Pin::className() const
 {
     return _className;
 }

src/kicad/model/pin.h

@@ -71,10 +71,10 @@ class KICAD_EXPORT Pin
         NonLogic
     };
 
-    QString name() const;
+    const QString &name() const;
     void setName(const QString &name);
 
-    QPoint pos() const;
+    const QPoint &pos() const;
     void setPos(const QPoint &pos);
     void setPos(int x, int y);
 
@@ -83,12 +83,12 @@ class KICAD_EXPORT Pin
     Direction direction() const;
     void setDirection(Pin::Direction direction);
 
-    QString padName() const;
+    const QString &padName() const;
     void setPadName(const QString &padname);
 
     PinType pinType() const;
     static QString pinTypeDesc(Pin::PinType pinType);
-    void setPinType(const PinType &pinType);
+    void setPinType(PinType pinType);
 
     ElectricalType electricalType() const;
     static QString electricalTypeDesc(Pin::ElectricalType electricalType);
@@ -106,13 +106,13 @@ class KICAD_EXPORT Pin
     int length() const;
     void setLength(int length);
 
-    QString className() const;
+    const QString &className() const;
     void setClassName(const QString &className);
 
     Component *component() const;
     void setComponent(Component *component);
 
-    friend bool operator<(const Pin &pin1, const Pin &pin);
+    friend bool operator<(const Pin &pin1, const Pin &pin2);
     friend bool operator==(const Pin &pin1, const Pin &pin2);
 
 private: