Fixes for Qt code

Since Qt objects are based on reference counting/garbage collection, they can have
some unexpected behaviors, specifically when dealing with lists. I have fixed many
instance of different Qt related issues after being identified using Clazy.

https://github.com/KDE/clazy/blob/1.11/docs/checks/README-range-loop-detach.md
https://github.com/KDE/clazy/blob/1.11/docs/checks/README-detaching-temporary.md
https://github.com/KDE/clazy/blob/1.11/docs/checks/README-use-static-qregularexpression.md
https://github.com/KDE/clazy/blob/1.11/docs/checks/README-qproperty-without-notify.md

Author: GravisZro

src/kicad/itemmodel/componentlibtreeview.cpp

@@ -130,7 +130,7 @@ void ComponentLibTreeView::remove()
             return;
         }
         QList<QPersistentModelIndex> pindex;
-        for (QModelIndex selected : selection)
+        for (QModelIndex selected : qAsConst(selection))
         {
             const QModelIndex &indexComponent = _sortProxy->mapToSource(selected);
             if (!indexComponent.isValid() || indexComponent.column() != 0)

src/kicad/itemmodel/componentpinsitemmodel.cpp

@@ -300,7 +300,7 @@ QString ComponentPinsItemModel::toNumeric(const QString &str)
 {
     QString sortPatern = str;
 
-    QRegularExpression numPattern("([^0-9]*)([0-9]+)([^0-9]*)", QRegularExpression::CaseInsensitiveOption);
+    static QRegularExpression numPattern("([^0-9]*)([0-9]+)([^0-9]*)", QRegularExpression::CaseInsensitiveOption);
 
     QRegularExpressionMatchIterator numMatchIt = numPattern.globalMatch(str);
     if (numMatchIt.hasNext())
@@ -322,7 +322,7 @@ void ComponentPinsItemModel::updateHigherPin()
     _higherPin.clear();
     if (_component != nullptr)
     {
-        for (Pin *pin : _component->pins())
+        for (Pin *pin : qAsConst(_component->pins()))
         {
             QString numPin = toNumeric(pin->padName());
             if (numPin > higherNumPin)
@@ -331,7 +331,7 @@ void ComponentPinsItemModel::updateHigherPin()
                 higherNumPin = numPin;
             }
         }
-        QRegularExpression higherNumPinPattern("([A-Z]*0*)([1-9][0-9]*)", QRegularExpression::CaseInsensitiveOption);
+        static QRegularExpression higherNumPinPattern("([A-Z]*0*)([1-9][0-9]*)", QRegularExpression::CaseInsensitiveOption);
         QRegularExpressionMatchIterator higherNumPinMatchIt = higherNumPinPattern.globalMatch(_higherPin);
         if (higherNumPinMatchIt.hasNext())
         {

src/kicad/itemmodel/componentpinstableview.cpp

@@ -131,7 +131,7 @@ void ComponentPinsTableView::remove()
     if (!selection.empty())
     {
         QList<QPersistentModelIndex> pindex;
-        for (QModelIndex selected : selection)
+        for (QModelIndex selected : qAsConst(selection))
         {
             const QModelIndex &indexComponent = _sortProxy->mapToSource(selected);
             if (!indexComponent.isValid())
@@ -179,7 +179,8 @@ void ComponentPinsTableView::updateSelect(const QItemSelection &selected, const
     Q_UNUSED(deselected)
 
     QSet<Pin *> selectedPins;
-    for (const QModelIndex &index : selectionModel()->selectedIndexes())
+    const auto& selected_idx = selectionModel()->selectedIndexes();
+    for (const QModelIndex &index : selected_idx)
     {
         if (!index.isValid())
         {

src/kicad/ksseditor/ksssyntax.cpp

@@ -46,7 +46,7 @@ KSSSyntax::KSSSyntax(QTextDocument *parent)
                     << "label"
                     << "rect"
                     << "priority";
-    for (const QString &pattern : keywordPatterns)
+    for (const QString &pattern : qAsConst(keywordPatterns))
     {
         rule.pattern.setPattern("\\b(" + pattern + ")\\b");
         rule.format = keywordFormat;
@@ -89,7 +89,7 @@ KSSSyntax::KSSSyntax(QTextDocument *parent)
                        << "faledge"
                        << "nologic";
 
-    for (const QString &pattern : enumvaluesPatterns)
+    for (const QString &pattern : qAsConst(enumvaluesPatterns))
     {
         rule.pattern.setPattern("\\b(" + pattern + ")\\b");
         rule.format = enumvaluesFormat;
@@ -117,7 +117,7 @@ void KSSSyntax::highlightBlock(const QString &text)
     PartToHighlight highlight;
 
     partsToHighlight.clear();
-    for (const HighlightingRule &rule : highlightingRules)
+    for (const HighlightingRule &rule : qAsConst(highlightingRules))
     {
         QRegularExpressionMatch match = rule.pattern.match(text);
         if (match.hasMatch())

src/kicad/pinruler/pinclass.cpp

@@ -122,10 +122,10 @@ void PinClass::sortPins()
         return;
     }
 
-    QRegularExpression pattern(_sortPattern, QRegularExpression::CaseInsensitiveOption);
-    QRegularExpression numPattern("([^0-9]*)([0-9]+)([^0-9]*)", QRegularExpression::CaseInsensitiveOption);
+    static QRegularExpression pattern(_sortPattern, QRegularExpression::CaseInsensitiveOption);
+    static QRegularExpression numPattern("([^0-9]*)([0-9]+)([^0-9]*)", QRegularExpression::CaseInsensitiveOption);
 
-    for (PinClassItem *pinItem : _pins)
+    for (PinClassItem *pinItem : qAsConst(_pins))
     {
         QString sortPatern;
         QString pinName = pinItem->pin()->name();
@@ -220,7 +220,7 @@ void PinClass::setPos(const QPoint &basePos)
             break;
     }
     sortPins();
-    for (PinClassItem *pinItem : _pins)
+    for (PinClassItem *pinItem : qAsConst(_pins))
     {
         pinItem->pin()->setAngle(angle);
         pinItem->pin()->setPos(pinPos + translate);

src/kicad/pinruler/pinruler.cpp

@@ -59,7 +59,7 @@ void PinRuler::organize(Component *component)
     component->clearDraws();
 
     PinClass *defaultClass = pinClass("default");
-    for (Pin *pin : component->pins())
+    for (Pin *pin : qAsConst(component->pins()))
     {
         PinClassItem *pinClassItem = new PinClassItem(pin);
         const QList<PinRule *> &rules = _ruleSet->rulesForPin(pin->name());
@@ -131,7 +131,7 @@ void PinRuler::organize(Component *component)
     QSize leftSize = QSize(0, 0);
     QSize rightSize = QSize(0, 0);
     QSize removedSize = QSize(0, 0);
-    for (PinClass *mpinClass : _pinClasses)
+    for (PinClass *mpinClass : qAsConst(_pinClasses))
     {
         if (mpinClass->pins().count() == 0)
         {
@@ -337,7 +337,7 @@ void PinRuler::organize(Component *component)
     component->refText()->setTextHJustify(DrawText::TextHLeft);
     component->refText()->setDirection(DrawText::DirectionHorizontal);
 
-    for (PinClass *mpinClass : _pinClasses)
+    for (PinClass *mpinClass : qAsConst(_pinClasses))
     {
         delete mpinClass;
         mpinClass = nullptr;

src/kicad/pinruler/rulesparser.cpp

@@ -176,8 +176,8 @@ void RulesParser::skipSpaceAndComments()
 
 QString RulesParser::getSelector()
 {
-    QRegularExpression rule(R"((\.?[a-zA-Z\(\[\.][/a-zA-Z0-9\+\-\[\]\(\)\_\|\\\*\.\^$\?:]*))");
-    QRegularExpressionMatch ruleMath = rule.match(_data.mid(_id));
+    static QRegularExpression rule(R"((\.?[a-zA-Z\(\[\.][/a-zA-Z0-9\+\-\[\]\(\)\_\|\\\*\.\^$\?:]*))");
+    static QRegularExpressionMatch ruleMath = rule.match(_data.mid(_id));
     if (ruleMath.hasMatch() && ruleMath.capturedStart() != 0)
     {
         return QString();
@@ -209,7 +209,7 @@ QString RulesParser::getSelector()
 
 QString RulesParser::getPropertyName()
 {
-    QRegularExpression rule("([a-zA-Z][a-zA-Z0-9\\_\\-]*)[\t ]*:[\t ]*", QRegularExpression::MultilineOption | QRegularExpression::DotMatchesEverythingOption);
+    static QRegularExpression rule("([a-zA-Z][a-zA-Z0-9\\_\\-]*)[\t ]*:[\t ]*", QRegularExpression::MultilineOption | QRegularExpression::DotMatchesEverythingOption);
     QRegularExpressionMatch ruleMath = rule.match(_data.mid(_id));
     if (ruleMath.hasMatch() && ruleMath.capturedStart() != 0)
     {
@@ -221,7 +221,7 @@ QString RulesParser::getPropertyName()
 
 QString RulesParser::getPropertyValue()
 {
-    QRegularExpression rule(R"lit("?([a-zA-Z0-9/^\?\$\|:\_\-\+\\\[\]\(\)\.\* ]*)"?;?)lit",
+    static QRegularExpression rule(R"lit("?([a-zA-Z0-9/^\?\$\|:\_\-\+\\\[\]\(\)\.\* ]*)"?;?)lit",
                             QRegularExpression::MultilineOption | QRegularExpression::DotMatchesEverythingOption);
     QRegularExpressionMatch ruleMath = rule.match(_data.mid(_id));
     if (ruleMath.hasMatch() && ruleMath.capturedStart() != 0)

src/kicad/viewer/componentitem.cpp

@@ -59,7 +59,7 @@ void ComponentItem::setComponent(Component *component, int unit)
     _pinItemMap.clear();
     _unit = unit;
 
-    for (Pin *pin : component->pins())
+    for (Pin *pin : qAsConst(component->pins()))
     {
         if (pin->unit() == _unit || pin->unit() == 0)
         {
@@ -68,7 +68,7 @@ void ComponentItem::setComponent(Component *component, int unit)
             _pinItemMap.insert(pin, pinItem);
         }
     }
-    for (Draw *draw : component->draws())
+    for (Draw *draw : qAsConst(component->draws()))
     {
         if (draw->unit() == _unit || draw->unit() == 0)
         {
@@ -117,7 +117,7 @@ void ComponentItem::setShowElectricalType(bool showElectricalType)
 {
     if (showElectricalType != _showElectricalType)
     {
-        for (PinItem *pinItem : _pinItemMap)
+        for (PinItem *pinItem : qAsConst(_pinItemMap))
         {
             pinItem->setShowElectricalType(showElectricalType);
         }

src/kicad/viewer/componentviewer.cpp

@@ -166,7 +166,8 @@ void ComponentViewer::selectedItem()
 {
     QList<Pin *> selectedPins;
 
-    for (QGraphicsItem *item : scene()->selectedItems())
+    const auto& selected = scene()->selectedItems();
+    for (QGraphicsItem *item : selected)
     {
         PinItem *pinItem = qgraphicsitem_cast<PinItem *>(item);
         selectedPins.append(pinItem->pin());

src/kicad/viewer/drawpolyitem.cpp

@@ -49,7 +49,7 @@ void DrawPolyItem::paint(QPainter *painter, const QStyleOptionGraphicsItem *opti
     }
 
     QPolygon poly;
-    for (QPoint pt : _drawPoly->points())
+    for (QPoint pt : qAsConst(_drawPoly->points()))
     {
         poly.append(pt / ComponentItem::ratio);
     }
@@ -67,7 +67,7 @@ void DrawPolyItem::setDraw(DrawPoly *draw)
     _drawPoly = draw;
     QRect mrect(0, 0, 1, 1);
 
-    for (QPoint pt : _drawPoly->points())
+    for (QPoint pt : qAsConst(_drawPoly->points()))
     {
         mrect = mrect.united(QRect(pt / ComponentItem::ratio, QSize(1, 1)));
     }