Conversation
1/ Length of tested string The default size uConfig uses to test a string extracted from a pdf is 10. Sometimes it is too short. You see some vanishing pins. 2/ Delete a part of the pin name Sometimes pin names have a prefix like (GPIO)P2[4] Now you get P2[4] instead.
|
Thank you very much for your interrest and your contribution. You perfectly understand that this parameter (pinNameLength) is a key to remove false positives and need to be tuned between different manufacturers. This one need to be added as a configuration of pdf_extractor. But you should not pass as an argument of the methods extractPins or pinSearch. It should be pass as a setter method or maybe better, inside a struct that contain all theses type of tweak name. For your second suggestion, I think deleteString cannot be put in pdf_extractor. It's not is role to do that. This parametter maybe added to the pinruler system, after the extraction and moved to kss file rule. What do you think ? |
|
Hello Seb I used the "search and replace" deleteString just where you added your "delete notes" regexp. Thus, for me, the tweak is applied at the right moment. The other tweak (pinNamelength) followed the exact same path. From "15" to GUI. Now, passing some parameters from the GUI to the core inside of a function, no idea what is best. Passing param as function argument is normal for me. |
1/ Length of tested string
The default size uConfig uses to test a string extracted from a pdf is
10. Sometimes it is too short. You see some vanishing pins.
2/ Delete a part of the pin name
Sometimes pin names have a prefix like (GPIO)P2[4]
Now you get P2[4] instead.
Almost every pin is skipped because the name is >10 chars


Package complete without the prefix. Note pin7 have a false name extracted from the "Page 15 of 45"
I have problems with Qstring and extracting ascii from it. Maybe some lines can be rewritten.