Open
Conversation
GravisZro
force-pushed
the
pdf-overhaul
branch
12 times, most recently
from
d8a45b8 to
94eda0e
Compare
Many variables were not initialized or were initialized only after complex code execution. Variables (especially pointers!!!) should ALWAYS be initialized at the start of the constructor in order to avoid uninitialized values while debugging code in the constructor. Always assign deleted pointers to nullptr for extra safety. I know it's against your style but I very much hope you adopt this style because it will save you from finding yourself in "impossible" situations.
Included files that are relative to the current directory should be included as such: \#include "relative_path/file.h" Included files that are relative to an included path should be included as such: \#include <some_path/file.h> The fact that they worked is somewhat of a bug and they may not always be the case.
The program has been using objects in freed memory for a very long time.
Since Qt objects are based on reference counting/garbage collection, they can have some unexpected behaviors, specifically when dealing with lists. I have fixed many instance of different Qt related issues after being identified using Clazy. https://github.com/KDE/clazy/blob/1.11/docs/checks/README-range-loop-detach.md https://github.com/KDE/clazy/blob/1.11/docs/checks/README-detaching-temporary.md https://github.com/KDE/clazy/blob/1.11/docs/checks/README-use-static-qregularexpression.md https://github.com/KDE/clazy/blob/1.11/docs/checks/README-qproperty-without-notify.md
I used re-structured the code to be more OO compliant. However, the main extraction loop was heavily modified to be readable. Some unused files were deleted and removed from the project file. Project file options were unified and updated for Appveyor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used re-structured the code to be more OO compliant. However, the main extraction loop was heavily modified to be readable. Some unused files were deleted and removed from the project file. This is a much cleaner implementation, so please merge it.
I did this because I was curious about how the actual extraction process worked. I now have some ideas for identifying labeled packages but this had to be cleaned up first.
Note: the project files were modified to fix the Appveyor build issue with including poppler-qt headers