fix(project): handle UUID temp names and tree filters

Author: Rocket-Quack

time_tracking/time_tracking/doctype/time_booking/time_booking.py

@@ -20,11 +20,15 @@
 
 
 class TimeBooking(Document):
-	def autoname(self):
-		if self.name:
+	def before_naming(self):
+		if not self.name:
 			return
-		# Use UUID without hyphens for stable external references (e.g. imports).
-		self.name = uuid.uuid4().hex
+		try:
+			uuid.UUID(str(self.name))
+		except (TypeError, ValueError, AttributeError):
+			# Desk creates temporary names like `new-time-booking-...`.
+			# For UUID doctypes, these must be cleared so Frappe can assign a real UUID.
+			self.name = None
 
 	def before_insert(self):
 		self._set_booking_code()

time_tracking/time_tracking/doctype/time_tracking_project/test_time_tracking_project.py

@@ -1,6 +1,7 @@
 import frappe
 from frappe.tests.utils import FrappeTestCase
 from frappe.utils import today
+from uuid import UUID
 
 
 class TestTimeTrackingProject(FrappeTestCase):
@@ -29,3 +30,17 @@ def test_project_name_duplicate_fails(self):
 
 		with self.assertRaises(Exception):
 			self._make_project(child_name, parent=parent.name)
+
+	def test_temporary_frontend_name_is_replaced_with_uuid(self):
+		doc = frappe.get_doc(
+			{
+				"doctype": "Time Tracking Project",
+				"name": "new-time-tracking-project-gsdzaapdej",
+				"project_name": self._unique("UI Project"),
+			}
+		)
+		doc.insert(ignore_permissions=True)
+
+		self.assertNotEqual(doc.name, "new-time-tracking-project-gsdzaapdej")
+		self.assertFalse(doc.name.startswith("new-time-tracking-project-"))
+		UUID(doc.name)

time_tracking/time_tracking/doctype/time_tracking_project/time_tracking_project.py

@@ -29,11 +29,15 @@ def _is_admin(user=None):
 
 
 class TimeTrackingProject(Document):
-	def autoname(self):
-		if self.name:
+	def before_naming(self):
+		if not self.name:
 			return
-		# Use UUID without hyphens for stable external references (e.g. imports).
-		self.name = uuid.uuid4().hex
+		try:
+			uuid.UUID(str(self.name))
+		except (TypeError, ValueError, AttributeError):
+			# Desk creates temporary names like `new-time-tracking-project-...`.
+			# For UUID doctypes, these must be cleared so Frappe can assign a real UUID.
+			self.name = None
 
 	def validate(self):
 		self._ensure_project_status()
@@ -450,7 +454,13 @@ def recalculate_all_project_metrics():
 @frappe.whitelist()
 def get_project_tree_nodes(doctype, parent="", **filters):
 	parent_field = "parent_" + frappe.scrub(doctype)
-	tree_filters = [[f"ifnull(`{parent_field}`,'')", "=", parent], ["docstatus", "<", 2]]
+	tree_filters = [["docstatus", "<", 2]]
+	or_filters = None
+
+	if parent:
+		tree_filters.append([parent_field, "=", parent])
+	else:
+		or_filters = [[parent_field, "is", "not set"], [parent_field, "=", ""]]
 
 	rows = frappe.get_list(
 		doctype,
@@ -469,6 +479,7 @@ def get_project_tree_nodes(doctype, parent="", **filters):
 			"total_budget_amount",
 		],
 		filters=tree_filters,
+		or_filters=or_filters,
 		order_by="name",
 	)